Skip to content
This repository was archived by the owner on Apr 8, 2025. It is now read-only.

rel/CY2310#1090

Open
Andrzej-Zukowski wants to merge 22 commits intomasterfrom
rel/CY2310
Open

rel/CY2310#1090
Andrzej-Zukowski wants to merge 22 commits intomasterfrom
rel/CY2310

Conversation

@Andrzej-Zukowski
Copy link
Collaborator

Purpose

Resolves #1084

Describe your changes

PR checklist

  • Add link to the issue
  • Choose Project
  • Choose PR label
  • New unit tests added
  • Modified code has meaningful comments
  • All TODOs are linked with the issues
  • All comments are resolved

Testing

Provide test details

Signed-off-by: Andrzej Zukowski <andrzej.zukowski@dell.com>
Signed-off-by: Andrzej Zukowski <andrzej.zukowski@dell.com>
@Andrzej-Zukowski Andrzej-Zukowski changed the title Rel/cy2310 rel/CY2310 Feb 21, 2024
@codecov
Copy link

codecov bot commented Feb 21, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 12 lines in your changes missing coverage. Please review.

Project coverage is 72.79%. Comparing base (6dbf230) to head (c0ea32c).
Report is 33 commits behind head on master.

Current head c0ea32c differs from pull request most recent head d505495

Please upload reports for the commit d505495 to get more accurate results.

Files Patch % Lines
pkg/scheduler/extender/extender.go 0.00% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1090      +/-   ##
==========================================
- Coverage   72.84%   72.79%   -0.06%     
==========================================
  Files          63       63              
  Lines        8949     8953       +4     
==========================================
- Hits         6519     6517       -2     
- Misses       2142     2148       +6     
  Partials      288      288              
Flag Coverage Δ
unittests 72.79% <25.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Andrzej-Zukowski and others added 20 commits February 22, 2024 10:45
Signed-off-by: Andrzej Zukowski <andrzej.zukowski@dell.com>
* Finding drive vid in lsblk vendor

* addressing review comments

* Initializing device

---------
…#1098)

* [Issue #1096] - Fix lint error for bug atl-22498

Signed-off-by: Eddie Pavkovic <eddie.pavkovic@dell.com>

* [Issue #1096] - Put code back that returned device if path set
- to fix unit test

Signed-off-by: Eddie Pavkovic <eddie.pavkovic@dell.com>

* [ISSUE-1096] - Put back code from previous PR and removed invalid test case

Signed-off-by: Eddie Pavkovic <eddie.pavkovic@dell.com>

---------

Signed-off-by: Eddie Pavkovic <eddie.pavkovic@dell.com>
Signed-off-by: rafalw82 <rafal.wegrzyn@dell.com>
Signed-off-by: rafalw82 <rafal.wegrzyn@dell.com>
* [ISSUE-1145]: use a serial number to compare drives



* [ISSUE-1145]: loopbacks fix



* [ISSUE-1145]: cr notes



* [ISSUE-1145]: fixed error msg



---------

Signed-off-by: Dawid Korzepa <dawid.korzepa@dell.com>
Signed-off-by: rafalw82 <rafal.wegrzyn@dell.com>
… table syncing (#1183)

Signed-off-by: Andrzej Zukowski <andrzej.zukowski@dell.com>
Signed-off-by: rafalw82 <rafal.wegrzyn@dell.com>
* [ISSUE-1230] trigger halmgr build

Signed-off-by: rafalw82 <rafal.wegrzyn@dell.com>
Signed-off-by: rafalw82 <rafal.wegrzyn@dell.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Scheduler extender algorithm modification

8 participants