Skip to content

Support csi-powerscale remoteAzNetwork parameter in storage class generation#314

Merged
lukeatdell merged 6 commits intomainfrom
usr/lukeatdell/multi-az-tenant
Sep 5, 2025
Merged

Support csi-powerscale remoteAzNetwork parameter in storage class generation#314
lukeatdell merged 6 commits intomainfrom
usr/lukeatdell/multi-az-tenant

Conversation

@lukeatdell
Copy link
Contributor

@lukeatdell lukeatdell commented Sep 3, 2025

Description

Update repctl to add support for generating replication-ready, csi-powerscale storage classes containing both AzNetwork and replication.storage.dell.com/remoteAzNetwork parameters.

GitHub Issues

GitHub Issue #
https://github.com/dell/csm/issues/1991

Checklist:

  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

  • Added and ran A/B tests for generating csi-powerscale storage classes with repctl.
  • Applied generated storage classes to a replicated cluster and provisioned storage on both sides.

@lukeatdell lukeatdell marked this pull request as ready for review September 4, 2025 16:48
falfaroc
falfaroc previously approved these changes Sep 5, 2025
@falfaroc
Copy link
Contributor

falfaroc commented Sep 5, 2025

Rebase 👍🏽

falfaroc
falfaroc previously approved these changes Sep 5, 2025
santhoshatdell
santhoshatdell previously approved these changes Sep 5, 2025
Copy link
Contributor

@santhoshatdell santhoshatdell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copyright info is missing for new files.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2025

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/dell/csm-replication/repctl/pkg/cmd 0.00% (ø)
github.com/dell/csm-replication/repctl/test/storageclass 0.00% (ø)

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/dell/csm-replication/repctl/pkg/cmd/create.go 0.00% (ø) 0 0 0
github.com/dell/csm-replication/repctl/test/storageclass/generated.go 0.00% (ø) 0 0 0

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/dell/csm-replication/repctl/test/storageclass/generate_test.go

@lukeatdell lukeatdell merged commit cb994ce into main Sep 5, 2025
11 of 12 checks passed
@lukeatdell lukeatdell deleted the usr/lukeatdell/multi-az-tenant branch September 5, 2025 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants