Skip to content

Adding Powermax replication group action#317

Closed
abhi16394 wants to merge 1 commit intomainfrom
usr/murala7/powermax-replication
Closed

Adding Powermax replication group action#317
abhi16394 wants to merge 1 commit intomainfrom
usr/murala7/powermax-replication

Conversation

@abhi16394
Copy link
Contributor

@abhi16394 abhi16394 commented Sep 5, 2025

Description

This PR addresses gaps in karavi replication tests for powermax driver.
Powermax was missing an action for a replication group which would eventually fail the karavi tests.
Adding the "ESTABLISH" action for powermax helps in creating replication group.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
https://github.com/dell/csm/issues/2001

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

I had successfull sync and async replication run with powermax driver

@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2025

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/dell/csm-replication/repctl/pkg/cmd 0.00% (ø)
github.com/dell/csm-replication/repctl/pkg/config 0.00% (ø)

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/dell/csm-replication/repctl/pkg/cmd/action.go 0.00% (ø) 0 0 0
github.com/dell/csm-replication/repctl/pkg/config/constants.go 0.00% (ø) 0 0 0

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/dell/csm-replication/repctl/pkg/cmd/action_test.go

@abhi16394 abhi16394 deleted the usr/murala7/powermax-replication branch September 5, 2025 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant