Migrate delta's golden table tests: snapshot tests and comparison script#51
Open
zachschuermann wants to merge 3 commits intodelta-incubator:mainfrom
Open
Migrate delta's golden table tests: snapshot tests and comparison script#51zachschuermann wants to merge 3 commits intodelta-incubator:mainfrom
zachschuermann wants to merge 3 commits intodelta-incubator:mainfrom
Conversation
nicklan
requested changes
Jul 23, 2024
Contributor
nicklan
left a comment
There was a problem hiding this comment.
nice, mostly lgtm modulo a few comments.
| print(df2) | ||
|
|
||
| # Check schema compatibility (columns and types) | ||
| if df1.schema != df2.schema: |
Contributor
There was a problem hiding this comment.
can't we just use assertDataFrameEqual and assertSchemaEqual
| .mode("overwrite") \ | ||
| .save(table_path) | ||
|
|
||
| @reference_table(name="snapshot-data0", description="golden tables snapshot-data0 test") |
Contributor
There was a problem hiding this comment.
i know these are the names from the golden tests in delta. they are really not descriptive :) If you know a bit more what they are testing maybe we can rename them to add a little more color.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adding delta's existing golden table tests to DAT. This PR introduces just a small first batch (the first 'snapshot' tests) and a comparison utility which was used to compare the tables produced by the new pyspark code with the tables produced by the old delta golden table code (and persisted in the delta repo).
The tests are first translated to pyspark, then can be tested by generating the tables and using the comparison utility to check that the latest snapshot matches (more advanced tests might take manual checking to confirm). Also ran these tests against delta-kernel-rs and so far all green :)
How was this patch tested?