feat: Complete schema diffing with map support #1481
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces core data structures for schema diffing: - SchemaDiff, FieldChange, FieldUpdate types - FieldChangeType enum for classifying changes - SchemaDiffError for validation errors - ColumnName::parent() helper method This is part 1/5 of the schema diffing feature implementation. The actual diffing algorithm will be added in PR 2. Note: This PR includes a temporary stub for compute_schema_diff() to allow basic tests to compile. The full implementation from the original PR delta-io#1346 will be copied exactly in PR 2. Related to delta-io#1346
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1481 +/- ##
==========================================
+ Coverage 84.84% 85.70% +0.86%
==========================================
Files 120 121 +1
Lines 32103 34147 +2044
Branches 32103 34147 +2044
==========================================
+ Hits 27238 29266 +2028
- Misses 3542 3549 +7
- Partials 1323 1332 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Adds a comprehensive unit test that exercises the filtering logic by manually constructing a SchemaDiff with both top-level and nested field changes. This test verifies that the methods correctly filter fields by path depth (length 1 vs length > 1). The test improves code coverage for these methods from 0% to full coverage of the filtering logic, addressing CI coverage requirements.
Adds complete diffing functionality for non-nested schemas: - Field collection and ID-based matching - Detection of adds, removes, renames, nullability changes - Physical name validation for column mapping - Breaking change classification - Full type classification including arrays and maps - Ancestor filtering for LCA reporting Currently supports flat schemas (top-level fields only). The collect_all_fields_with_paths() function has a commented-out recursive call that will be enabled in PR 3 to support nested fields. All other functions are copied exactly from the original PR delta-io#1346 (murali-db/schema-evol) with no logic changes. This is part 2/5 of the schema diffing feature implementation. Tests included (9 tests): - test_identical_schemas - test_change_count - test_top_level_added_field - test_added_required_field_is_breaking - test_added_nullable_field_is_not_breaking - test_physical_name_validation - test_multiple_change_types - test_multiple_with_breaking_change - test_duplicate_field_id_error Related to delta-io#1346
Adds a comprehensive unit test that exercises the filtering logic by manually constructing a SchemaDiff with both top-level and nested field changes. This test verifies that the methods correctly filter fields by path depth (length 1 vs length > 1). The test improves code coverage for these methods from 0% to full coverage of the filtering logic, addressing CI coverage requirements.
Extends schema diffing to handle nested structures: - Recursive field collection through struct hierarchies - Ancestor filtering to report only LCA changes - Type change classification for struct containers - Support for arbitrarily deep nesting Arrays and maps support coming in follow-up PRs. This is part 3/5 of the schema diffing feature implementation. Related to delta-io#1346 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Adds a comprehensive unit test that exercises the filtering logic by manually constructing a SchemaDiff with both top-level and nested field changes. This test verifies that the methods correctly filter fields by path depth (length 1 vs length > 1). The test improves code coverage for these methods from 0% to full coverage of the filtering logic, addressing CI coverage requirements.
Adds 8 comprehensive array tests: - Array element struct field changes - Doubly nested array type changes - Nested array nullability (loosened/tightened) - Inner array nullability (loosened/tightened) - Simple array nullability (loosened/tightened) All array implementation code was already present from PR 2. This PR only adds tests to verify array functionality. This is part 4/5 of the schema diffing feature implementation. Related to delta-io#1346 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Adds a comprehensive unit test that exercises the filtering logic by manually constructing a SchemaDiff with both top-level and nested field changes. This test verifies that the methods correctly filter fields by path depth (length 1 vs length > 1). The test improves code coverage for these methods from 0% to full coverage of the filtering logic, addressing CI coverage requirements.
murali-db
force-pushed
the
murali-db/schema-diff-pr5
branch
from
1b82910 to
713b5d2
Compare
Completes the schema diffing implementation with map support: - Map key and value type tracking and comparison - Map value nullability change detection (loosened/tightened) - Struct keys and values within maps - Deeply nested scenarios mixing structs, arrays, and maps This is the final PR in the series that enables the schema diff functionality. The feature gate has been removed - implementation is now active. Test additions: - test_map_value_struct_field_changes - test_map_nullability_loosened - test_map_nullability_tightened - test_map_with_struct_key - test_cursed_deeply_nested_complex_types Note: #![allow(dead_code)] is retained as the API is not yet integrated with other modules. This is the final part (5/5) of the schema diffing feature implementation. Related to delta-io#1346 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
murali-db
force-pushed
the
murali-db/schema-diff-pr5
branch
from
713b5d2 to
b2bb992
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part 5 of 5 PRs that implement schema diffing for Delta Kernel Rust.
What's in this PR
Map tests covering:
Changes
MapTypeto test module importsHashSetimport for set operations in tests#![allow(dead_code)]as API is not yet integrated with other modulesFeature Gating
This PR removes the feature gate introduced in PR #1477, fully enabling the schema diff functionality.
Related
This is the final PR in the series. Closes #1346.
🤖 Generated with Claude Code