Skip to content

Conversation

@aleksandarskrbic
Copy link
Contributor

What changes are proposed in this pull request?

Fixes: #1370

How was this change tested?

@codecov
Copy link

codecov bot commented Nov 14, 2025

Codecov Report

❌ Patch coverage is 98.78935% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.76%. Comparing base (3bcd274) to head (1d5c0c5).

Files with missing lines Patch % Lines
kernel/src/scan/tests.rs 98.39% 2 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1485      +/-   ##
==========================================
- Coverage   84.76%   84.76%   -0.01%     
==========================================
  Files         122      124       +2     
  Lines       33032    33027       -5     
  Branches    33032    33027       -5     
==========================================
- Hits        28000    27995       -5     
  Misses       3659     3659              
  Partials     1373     1373              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@nicklan nicklan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, this lgtm. could you briefly say why you moved some stuff to test_utils.rs? I see that they are utility functions, but unless they are used in other test modules, I'd just put them all in tests.rs.

@aleksandarskrbic
Copy link
Contributor Author

thanks, this lgtm. could you briefly say why you moved some stuff to test_utils.rs? I see that they are utility functions, but unless they are used in other test modules, I'd just put them all in tests.rs.

@nicklan I've added them to test utils since some of those methods are used in state and log_replay module

@aleksandarskrbic aleksandarskrbic force-pushed the aleksandarskrbic/refactor/scan-tests branch from 49662b0 to 415f2ce Compare November 18, 2025 08:36
@nicklan nicklan requested review from emkornfield and removed request for zachschuermann November 21, 2025 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move the scan/mod.rs tests to their own file

2 participants