-
Notifications
You must be signed in to change notification settings - Fork 123
refactor: move scan/mod.rs to scan/tests.rs and scan/test_utils.rs #1485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
refactor: move scan/mod.rs to scan/tests.rs and scan/test_utils.rs #1485
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1485 +/- ##
==========================================
- Coverage 84.76% 84.76% -0.01%
==========================================
Files 122 124 +2
Lines 33032 33027 -5
Branches 33032 33027 -5
==========================================
- Hits 28000 27995 -5
Misses 3659 3659
Partials 1373 1373 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
nicklan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, this lgtm. could you briefly say why you moved some stuff to test_utils.rs? I see that they are utility functions, but unless they are used in other test modules, I'd just put them all in tests.rs.
@nicklan I've added them to test utils since some of those methods are used in |
49662b0 to
415f2ce
Compare
What changes are proposed in this pull request?
Fixes: #1370
How was this change tested?