feat: Commit Reader #1499
Draft
feat: Commit Reader #1499
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 19, 2025
scovich
reviewed
Nov 20, 2025
| use crate::scan::COMMIT_READ_SCHEMA; | ||
| use object_store::local::LocalFileSystem; | ||
| use std::path::PathBuf; | ||
| use std::sync::Arc as StdArc; |
Collaborator
There was a problem hiding this comment.
???
Is there some name collision that makes Arc unusable?
Collaborator
Author
There was a problem hiding this comment.
sigh Claude that day REALLY didn't want to use Arc. Also this should've stayed draft, mb
Collaborator
There was a problem hiding this comment.
Oh, it's marked draft. I just made a feedback pass because we've been iterating on this together anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🥞 Stacked PR
Use this link to review incremental changes.
What changes are proposed in this pull request?
How was this change tested?