refactor: migrated protocol validation tests to table_configuration #1517
+115
−153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1517 +/- ##
==========================================
+ Coverage 84.74% 84.76% +0.01%
==========================================
Files 122 122
Lines 32938 33103 +165
Branches 32938 33103 +165
==========================================
+ Hits 27914 28060 +146
+ Misses 3674 3668 -6
- Partials 1350 1375 +25 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
DrakeLin
changed the title
OussamaSaoudi
approved these changes
Nov 22, 2025
Comment on lines
+1518
to
+1523
| let table_root = Url::try_from("file:///").unwrap(); | ||
| let config = TableConfiguration::try_new(metadata, protocol, table_root, 0).unwrap(); | ||
| assert_result_error_with_message( | ||
| config.ensure_write_supported(), | ||
| "rowTracking requires domainMetadata to be supported", | ||
| ); |
Collaborator
There was a problem hiding this comment.
Can you add a case for RowTracking + Domain metadata to show that adding the requirement fixes it?
nicklan
approved these changes
Nov 22, 2025
Member
nicklan
left a comment
nicklan
left a comment
There was a problem hiding this comment.
lgtm if nit addressed. thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Following #1411, move tests over.
The previous tests didn't validate protocol, so we had some tests where protocol was 2/7 but writer features didn't exist. Since we construct and validate protocol in the test helper, changed the test to include a writer feature.
How was this change tested?