Skip to content

chore: enable some column mapping tests #3677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

chore: enable some column mapping tests #3677

wants to merge 3 commits into from
+165 −4

Conversation

@rtyler
Copy link
Member

@rtyler rtyler commented Aug 15, 2025

No description provided.

@github-actions github-actions bot added the binding/rust Issues for the Rust crate label Aug 15, 2025
@codecov
Copy link

codecov bot commented Aug 15, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 18.97%. Comparing base (09ab871) to head (3c58dd2).

Files with missing lines Patch % Lines
crates/core/src/kernel/snapshot/replay.rs 0.00% 5 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (09ab871) and HEAD (3c58dd2). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (09ab871) HEAD (3c58dd2)
3 1
Additional details and impacted files 
@@             Coverage Diff             @@
##             main    #3677       +/-   ##
===========================================
- Coverage   75.37%   18.97%   -56.40%     
===========================================
  Files         144       73       -71     
  Lines       43607    11999    -31608     
  Branches    43607    11999    -31608     
===========================================
- Hits        32869     2277    -30592     
- Misses       9131     9540      +409     
+ Partials     1607      182     -1425

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

rtyler added 2 commits August 25, 2025 00:33
@rtyler
chore: enable some column mapping tests
5f79945 
Signed-off-by: R. Tyler Croy <[email protected]>
@rtyler
fix: enabling correctly pulling partition values out of column mapped…
e31e915 
… tables

Juggling this unit test took a *long* time but found a few other places
that needed to use the right names in the process 😩

Signed-off-by: R. Tyler Croy <[email protected]>
@rtyler rtyler force-pushed the feat/support-column-mapping branch from de21226 to e31e915 Compare August 25, 2025 00:35
@github-actions github-actions bot added binding/python Issues for the Python package delta-inspect labels Aug 25, 2025
@rtyler rtyler changed the base branch from next to main August 25, 2025 00:40
@github-actions github-actions bot removed delta-inspect binding/python Issues for the Python package labels Aug 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@roeap roeap Awaiting requested review from roeap roeap will be requested when the pull request is marked ready for review roeap is a code owner

@hntd187 hntd187 Awaiting requested review from hntd187 hntd187 will be requested when the pull request is marked ready for review hntd187 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

binding/rust Issues for the Rust crate

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@rtyler