Skip to content

Conversation

@roeap
Copy link
Collaborator

@roeap roeap commented Oct 18, 2025

Description

In one of @fvaleye's latest PRs (#3841), we got rid of the last call sites of file_actions on DeltaTableState. Since we generally discourage materialising Add actions and rather do processing/planning on the view into the underlying arrow data, it's high time we deprecate these methods and remove the last invocations within our tests.

This PR does just that.

@roeap roeap requested review from hntd187 and rtyler as code owners October 18, 2025 12:37
@github-actions github-actions bot added the binding/rust Issues for the Rust crate label Oct 18, 2025
@roeap roeap requested review from fvaleye and ion-elgreco October 18, 2025 12:38
@roeap roeap enabled auto-merge (squash) October 18, 2025 12:38
@codecov
Copy link

codecov bot commented Oct 18, 2025

Codecov Report

❌ Patch coverage is 72.09302% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.78%. Comparing base (a144752) to head (8dc9ef0).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/core/src/protocol/checkpoints.rs 0.00% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3863      +/-   ##
==========================================
- Coverage   73.83%   73.78%   -0.06%     
==========================================
  Files         151      151              
  Lines       39134    39127       -7     
  Branches    39134    39127       -7     
==========================================
- Hits        28895    28868      -27     
- Misses       8968     8989      +21     
+ Partials     1271     1270       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@roeap roeap merged commit 09e2a9b into delta-io:main Oct 18, 2025
25 of 26 checks passed
@roeap roeap deleted the chore/deprecate-file-actions branch October 18, 2025 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

binding/rust Issues for the Rust crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants