refactor: use BatchAdapterFactory for scan adaptation#4195
Merged
ion-elgreco merged 2 commits intodelta-io:mainfrom Feb 13, 2026
Merged
refactor: use BatchAdapterFactory for scan adaptation#4195ion-elgreco merged 2 commits intodelta-io:mainfrom
ion-elgreco merged 2 commits intodelta-io:mainfrom
Conversation
Signed-off-by: Ethan Urbanski <ethan@urbanskitech.com>
Signed-off-by: Ethan Urbanski <ethan@urbanskitech.com>
Collaborator
Author
|
FYI I have a follow up hardening PR on top of this |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #4195 +/- ##
==========================================
- Coverage 76.67% 76.67% -0.01%
==========================================
Files 166 166
Lines 47059 47099 +40
Branches 47059 47099 +40
==========================================
+ Hits 36082 36112 +30
- Misses 9195 9204 +9
- Partials 1782 1783 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ion-elgreco
approved these changes
Feb 13, 2026
Collaborator
ion-elgreco
left a comment
There was a problem hiding this comment.
Nice stuff with adding all the tests!
fvaleye
pushed a commit
to fvaleye/delta-rs
that referenced
this pull request
Feb 17, 2026
# Description Follow up to the DF 52 upgrade. Replaces custom scan batch casting logic with DataFusion's `BatchAdapterFactory` via `datafusion-physical-expr-adapter`. Adds hardening tests for schema evolution and DV scan behavior Keeps DF default behavior with no custom compatibility mode # Related Issue(s) <!--- For example: - closes #106 ---> # Documentation <!--- Share links to useful documentation ---> --------- Signed-off-by: Ethan Urbanski <ethan@urbanskitech.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow up to the DF 52 upgrade. Replaces custom scan batch casting logic
with DataFusion's
BatchAdapterFactoryviadatafusion-physical-expr-adapter.Adds hardening tests for schema evolution and DV scan behavior
Keeps DF default behavior with no custom compatibility mode
Related Issue(s)
Documentation