Skip to content

refactor: use BatchAdapterFactory for scan adaptation#4195

Merged
ion-elgreco merged 2 commits intodelta-io:mainfrom
ethan-tyler:feat/expr-adapter-targeted
Feb 13, 2026
Merged

refactor: use BatchAdapterFactory for scan adaptation#4195
ion-elgreco merged 2 commits intodelta-io:mainfrom
ethan-tyler:feat/expr-adapter-targeted

Conversation

@ethan-tyler
Copy link
Collaborator

Description

Follow up to the DF 52 upgrade. Replaces custom scan batch casting logic
with DataFusion's BatchAdapterFactory via datafusion-physical-expr-adapter.

Adds hardening tests for schema evolution and DV scan behavior

Keeps DF default behavior with no custom compatibility mode

Related Issue(s)

Documentation

Signed-off-by: Ethan Urbanski <ethan@urbanskitech.com>
Signed-off-by: Ethan Urbanski <ethan@urbanskitech.com>
@github-actions github-actions bot added the binding/rust Issues for the Rust crate label Feb 12, 2026
@ethan-tyler
Copy link
Collaborator Author

FYI I have a follow up hardening PR on top of this

@codecov
Copy link

codecov bot commented Feb 13, 2026

Codecov Report

❌ Patch coverage is 80.24691% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.67%. Comparing base (f157cdc) to head (5fe3a79).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...a_datafusion/table_provider/next/scan/exec_meta.rs 0.00% 10 Missing ⚠️
...c/delta_datafusion/table_provider/next/scan/mod.rs 91.54% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4195      +/-   ##
==========================================
- Coverage   76.67%   76.67%   -0.01%     
==========================================
  Files         166      166              
  Lines       47059    47099      +40     
  Branches    47059    47099      +40     
==========================================
+ Hits        36082    36112      +30     
- Misses       9195     9204       +9     
- Partials     1782     1783       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@ion-elgreco ion-elgreco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice stuff with adding all the tests!

@ion-elgreco ion-elgreco merged commit ef405d8 into delta-io:main Feb 13, 2026
26 checks passed
fvaleye pushed a commit to fvaleye/delta-rs that referenced this pull request Feb 17, 2026
# Description
Follow up to the DF 52 upgrade. Replaces custom scan batch casting logic
with DataFusion's `BatchAdapterFactory` via
`datafusion-physical-expr-adapter`.

Adds hardening tests for schema evolution and DV scan behavior

Keeps DF default behavior with no custom compatibility mode

# Related Issue(s)
<!---
For example:

- closes #106
--->

# Documentation

<!---
Share links to useful documentation
--->

---------

Signed-off-by: Ethan Urbanski <ethan@urbanskitech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

binding/rust Issues for the Rust crate

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants