fix: enforce file-id filter semantics in scan planning#4206
Merged
rtyler merged 2 commits intodelta-io:mainfrom Feb 16, 2026
Merged
fix: enforce file-id filter semantics in scan planning#4206rtyler merged 2 commits intodelta-io:mainfrom
rtyler merged 2 commits intodelta-io:mainfrom
Conversation
Signed-off-by: Ethan Urbanski <ethan@urbanskitech.com>
970aa42 to
c8cc6b5
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4206 +/- ##
==========================================
+ Coverage 76.71% 76.73% +0.01%
==========================================
Files 166 166
Lines 47782 47807 +25
Branches 47782 47807 +25
==========================================
+ Hits 36657 36683 +26
+ Misses 9289 9288 -1
Partials 1836 1836 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rtyler
reviewed
Feb 16, 2026
| return None; | ||
| } | ||
|
|
||
| let key = dict.keys().value(row) as usize; |
Member
There was a problem hiding this comment.
value() can panic if row isn't a valid offset. Can this bail earlier if the offset doesn't fit in the length of keys()?
Signed-off-by: Ethan Urbanski <ethan@urbanskitech.com>
auto-merge was automatically disabled
February 16, 2026 21:08
Head branch was pushed to by a user without write access
rtyler
approved these changes
Feb 16, 2026
Collaborator
Author
|
Thank you sir @rtyler! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Last DF 52 upgrade clean up PR
file_idis a synthetic scan column and is not a valid kernel/parquet pushdown target. Predicates referencingfile_idare now classified asUnsupportedand excluded from kernel/parquet predicate generation, keeping them as residual DataFusion filters.Non-
file_idbehavior unchanged: partition only filters remainExact, data-column-only filters remainInexact.Related Issue(s)
Documentation