chore: pin arro3-core under the 0.7.0 release#4221
Conversation
The 0.7.0 release seems to have broken a number of our tests which
perform tyep checks, e.g.
> assert table_schema.field("price").type == sample_table["price"].type
E AssertionError: assert DataType(int64) == arro3.core.DataType<Int64>\n
E + where DataType(int64) = pyarrow.Field<price: int64>.type
E + where pyarrow.Field<price: int64> = field('price')
E + where field = id: string\nprice: int64\nsold: int32\ndeleted: bool.field
E + and arro3.core.DataType<Int64>\n = arro3.core.ChunkedArray<Int64>\n[\n [\n 0,\n 1,\n 2,\n 3,\n 4,\n ]\n]\n.type
tests/test_merge.py:2400: AssertionError
Signed-off-by: R. Tyler Croy <rtyler@brokenco.de>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4221 +/- ##
==========================================
- Coverage 76.82% 76.81% -0.02%
==========================================
Files 166 166
Lines 48231 48209 -22
Branches 48231 48209 -22
==========================================
- Hits 37053 37030 -23
- Misses 9319 9321 +2
+ Partials 1859 1858 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: R. Tyler Croy <rtyler@brokenco.de>
|
Reported upstream here |
ion-elgreco
left a comment
There was a problem hiding this comment.
This pins the package, but we should only pin the dev dependency
|
@ion-elgreco if this release breaks our tests because datatypes are no longer equal, I don't believe we can trust it. I'm not sure what benefit only pinning the development dependency would be |
We don't do any comparisons between pyarrow and arro3 types so if should be fine! |
|
Looks like 0.8 got released, lets wait for that then it resolves itself |
The 0.7.0 release seems to have broken a number of our tests which
perform tyep checks, e.g.
Signed-off-by: R. Tyler Croy rtyler@brokenco.de