Skip to content

chore: pin arro3-core under the 0.7.0 release#4221

Closed
rtyler wants to merge 2 commits intomainfrom
robot-nixon-says-arroooooooo
Closed

chore: pin arro3-core under the 0.7.0 release#4221
rtyler wants to merge 2 commits intomainfrom
robot-nixon-says-arroooooooo

Conversation

@rtyler
Copy link
Member

@rtyler rtyler commented Feb 22, 2026

The 0.7.0 release seems to have broken a number of our tests which
perform tyep checks, e.g.

    >       assert table_schema.field("price").type == sample_table["price"].type
    E       AssertionError: assert DataType(int64) == arro3.core.DataType<Int64>\n
    E        +  where DataType(int64) = pyarrow.Field<price: int64>.type
    E        +    where pyarrow.Field<price: int64> = field('price')
    E        +      where field = id: string\nprice: int64\nsold: int32\ndeleted: bool.field
    E        +  and   arro3.core.DataType<Int64>\n = arro3.core.ChunkedArray<Int64>\n[\n  [\n    0,\n    1,\n    2,\n    3,\n    4,\n  ]\n]\n.type

    tests/test_merge.py:2400: AssertionError

Signed-off-by: R. Tyler Croy rtyler@brokenco.de

The 0.7.0 release seems to have broken a number of our tests which
perform tyep checks,  e.g.

        >       assert table_schema.field("price").type == sample_table["price"].type
        E       AssertionError: assert DataType(int64) == arro3.core.DataType<Int64>\n
        E        +  where DataType(int64) = pyarrow.Field<price: int64>.type
        E        +    where pyarrow.Field<price: int64> = field('price')
        E        +      where field = id: string\nprice: int64\nsold: int32\ndeleted: bool.field
        E        +  and   arro3.core.DataType<Int64>\n = arro3.core.ChunkedArray<Int64>\n[\n  [\n    0,\n    1,\n    2,\n    3,\n    4,\n  ]\n]\n.type

        tests/test_merge.py:2400: AssertionError

Signed-off-by: R. Tyler Croy <rtyler@brokenco.de>
@github-actions github-actions bot added the binding/python Issues for the Python package label Feb 22, 2026
@codecov
Copy link

codecov bot commented Feb 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.81%. Comparing base (fef97b8) to head (e28102e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4221      +/-   ##
==========================================
- Coverage   76.82%   76.81%   -0.02%     
==========================================
  Files         166      166              
  Lines       48231    48209      -22     
  Branches    48231    48209      -22     
==========================================
- Hits        37053    37030      -23     
- Misses       9319     9321       +2     
+ Partials     1859     1858       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: R. Tyler Croy <rtyler@brokenco.de>
@rtyler rtyler marked this pull request as ready for review February 22, 2026 23:06
@rtyler rtyler requested a review from ion-elgreco as a code owner February 22, 2026 23:06
@rtyler rtyler requested a review from hntd187 February 22, 2026 23:06
@rtyler rtyler enabled auto-merge (rebase) February 22, 2026 23:06
@rtyler
Copy link
Member Author

rtyler commented Feb 22, 2026

Reported upstream here

Copy link
Collaborator

@ion-elgreco ion-elgreco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pins the package, but we should only pin the dev dependency

@rtyler
Copy link
Member Author

rtyler commented Feb 22, 2026

@ion-elgreco if this release breaks our tests because datatypes are no longer equal, I don't believe we can trust it. I'm not sure what benefit only pinning the development dependency would be

@ion-elgreco
Copy link
Collaborator

@ion-elgreco if this release breaks our tests because datatypes are no longer equal, I don't believe we can trust it. I'm not sure what benefit only pinning the development dependency would be

We don't do any comparisons between pyarrow and arro3 types so if should be fine!

@ion-elgreco
Copy link
Collaborator

Looks like 0.8 got released, lets wait for that then it resolves itself

@rtyler rtyler disabled auto-merge February 23, 2026 13:49
@rtyler rtyler closed this Feb 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

binding/python Issues for the Python package

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants