Handle empty String nextPageToken correctly in DeltaSharingClient#777
Open
nightscape wants to merge 1 commit intodelta-io:mainfrom
Open
Handle empty String nextPageToken correctly in DeltaSharingClient#777nightscape wants to merge 1 commit intodelta-io:mainfrom
nightscape wants to merge 1 commit intodelta-io:mainfrom
Conversation
According to PROTOCOL.md, an empty String also means end of the list, so it should be handled identically to None.
Author
|
@linzhou-db @zsxwing @pranavsuku-db @chakankardb @PatrickJin-db @littlegrasscao this one should be quick to review, it's basically the same as the already-merged PR for Python: https://github.com/delta-io/delta-sharing/pull/530/files |
Author
|
@linzhou-db @zsxwing @pranavsuku-db @chakankardb @PatrickJin-db @littlegrasscao any chance of getting a review on this? |
chakankardb
reviewed
Sep 1, 2025
| shares ++= response.items | ||
| } | ||
| while (response.nextPageToken.nonEmpty) { | ||
| while (response.nextPageToken.exists(_.nonEmpty)) { |
Collaborator
There was a problem hiding this comment.
Can we add a unit test for this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to PROTOCOL.md, an empty String also means end of the list, so it should be handled identically to None.