resolve fixmes in tool_wallet.py: wallet file shasum unchanged for both legacy and descriptor wallets. replaceable=True must be set explicitly in sendtoaddress as walletrbf=0 is set by default in the test_framework wallet config (test_framework/util.py:421)

(cherry picked from commit 445a913)

Author: Tom Trevethan

test/functional/tool_wallet.py

@@ -258,8 +258,7 @@ def test_tool_wallet_info_after_transaction(self):
         # TODO: Wallet tool info should not write to the wallet file.
         # This assertion should be uncommented and succeed:
         # assert_equal(timestamp_before, timestamp_after)
-        if not self.options.descriptors: # ELEMENTS FIXME
-            assert_equal(shasum_before, shasum_after)
+        assert_equal(shasum_before, shasum_after)
         self.log.debug('Wallet file shasum unchanged\n')
 
     def test_tool_wallet_create_on_existing_wallet(self):
@@ -409,7 +408,7 @@ def test_chainless_conflicts(self):
         self.generate(self.nodes[0], 1)
 
         # parent tx
-        parent_txid = wallet.sendtoaddress(wallet.getnewaddress(), 9, replaceable=True) # ELEMENTS FIXME: replaceable should be true by default, investigate
+        parent_txid = wallet.sendtoaddress(wallet.getnewaddress(), 9, replaceable=True) # ELEMENTS: walletrbf=0 by default in test_framework wallet config
         parent_txid_bytes = bytes.fromhex(parent_txid)[::-1]
         conflict_utxo = wallet.gettransaction(txid=parent_txid, verbose=True)["decoded"]["vin"][0]
         value = sum([out["value"] for out in wallet.gettransaction(txid=parent_txid, verbose=True)["decoded"]["vout"]]) # ELEMENTS