Avoid rendering both the background and window on the same line#108
Open
ccawley2011 wants to merge 1 commit intodeltabeard:masterfrom
Open
Avoid rendering both the background and window on the same line#108ccawley2011 wants to merge 1 commit intodeltabeard:masterfrom
ccawley2011 wants to merge 1 commit intodeltabeard:masterfrom
Conversation
Owner
|
These changes causes failures in the DMG-Acid2 test as shown below.
Previously, the output was:
The left eye and the left chin are drawn by the background which is why they do not look correct after your changes (see https://github.com/mattcurrie/dmg-acid2?tab=readme-ov-file#eyes). The coordinates of the window can be changed to start at any x and y pixel. See https://gbdev.io/pandocs/Scrolling.html#ff4aff4b--wy-wx-window-y-position-x-position-plus-7 . The increase in speed was impressive though. 🙂 |
deltabeard
requested changes
Jun 13, 2024
Owner
deltabeard
left a comment
deltabeard
left a comment
There was a problem hiding this comment.
As mentioned in the previous comment, the behaviour of the window is now not functioning correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From what I understand, if the window is active on a given line it'll completely cover the background, so there's no need to draw both of them. In addition, this PR will only clear the buffer if neither the window nor the background are active, which improves performance a bit.