feat: add URL param to sync animation to ringtone#64
Conversation
This commit does not change the default behavior.
| :root { | ||
| --ring-animation-period: 0.8; | ||
| /* Default value, can be overridden in JS. */ | ||
| --ringtone-bpm: calc(60 / var(--ring-animation-period)); | ||
| } |
There was a problem hiding this comment.
I am not sure variables are supported in default webview in Android 5 🤔 this needs to be tested in old devices
There was a problem hiding this comment.
Has the app been tested on old devices at all? Because RTCPeerConnection has been introduced only in 2017 without a webkit wendor prefix. For CSS variables, it's 2016.
https://developer.mozilla.org/en-US/docs/Web/API/RTCPeerConnection
There was a problem hiding this comment.
I have pushed a fallback in case the browser doesn't support animations, taking the approach from this question: https://stackoverflow.com/questions/66770777/does-css-var-fallback-work-in-unsupported-browsers
|
Do I understand this right: the idea is that the frequency of the ringtone can be passed, to align the pulse of the animation with the frequency of the ringtone? |
|
Yes, basically. By frequency I mean "BPM". |
This commit does not change the default behavior.
(turn up the volume):
2025-10-11-nWhAMtiQgv.mp4