feat: Adapt to channel-invite QR codes #3886
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cloning wouldn't work, because you can only be added to a broadcast channel via a QR code
27 tasks
12 tasks
|
To test the changes in this pull request, install this apk: |
Hocuri
changed the title
Hocuri
force-pushed
the
hoc/channels-encryption-only-qrcodes
branch
from
72d991d to
3378f77
Compare
|
To test the changes in this pull request, install this apk: |
|
To test the changes in this pull request, install this apk: |
adbenitez
approved these changes
Oct 21, 2025
Hocuri
commented
Oct 23, 2025
| if (dcContext.sendMsg(dcChat.getId(), msg) == 0) { | ||
| Util.runOnMain(()-> Toast.makeText(ConversationActivity.this, dcContext.getLastError(), Toast.LENGTH_LONG).show()); | ||
| String lastError = dcContext.getLastError(); | ||
| if (!"".equals(lastError)) { |
There was a problem hiding this comment.
This check is so that we don't show an empty toast when sending a message into a legacy channel fails.
|
To test the changes in this pull request, install this apk: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion PR for chatmail/core#7268
DC_QR_ASK_JOIN_BROADCAST = 204(CFFI) /AskJoinBroadcast(JsonRPC)DC_QR_ASK_VERIFYGROUPandDC_QR_ASK_VERIFYCONTACT, just that the dialog shown after scanning uses the translated stringqrscan_ask_join_channelAdd membershould be hidden, and insteadQR Invite Codeshould be shownchat_new_channel_hintshould be shown.TODO:
jnifolder)