Skip to content

feat: do not use HTTPS request for default instant onboarding #5618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nicodh merged 2 commits into from
Nov 3, 2025
Merged

feat: do not use HTTPS request for default instant onboarding #5618

nicodh merged 2 commits into from
Nov 3, 2025

Conversation

@link2xt
Copy link
Collaborator

@link2xt link2xt commented Oct 28, 2025 •
edited
Loading

Depends on the core PR: chatmail/core#7360
Using domain name in dcaccount scheme works
similarly to existing scheme,
but no HTTPS request is made
and credentials are generated locally on the client.

@link2xt link2xt added the new-core involves or requires an core update label Oct 28, 2025
This was referenced Oct 28, 2025
Merged
Closed
@link2xt
Copy link
Collaborator Author

link2xt commented Oct 28, 2025

CI currently fails because of no core update.

@link2xt link2xt marked this pull request as draft October 28, 2025 01:29
@link2xt link2xt force-pushed the link2xt/dcaccount9 branch from bf4246b to 27f45d2 Compare October 28, 2025 02:35
@link2xt link2xt changed the title feat: dcaccount9 scheme support feat: do not use HTTPS request for default instant onboarding Oct 28, 2025
WofWca
WofWca reviewed Oct 28, 2025
View reviewed changes
Copy link
Member

@WofWca WofWca left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI also fails because there are still occurrences of DC_CHATMAIL_SERVER, namely in the GitHub workflow file.

Edit: also we don't have the var set in our repo's secrets / variables.

@link2xt link2xt marked this pull request as ready for review November 1, 2025 21:11
@link2xt
Copy link
Collaborator Author

link2xt commented Nov 1, 2025

We have core 2.23.0 now, so once it is updated, this PR can be rebased.

@link2xt @nicodh
feat: do not use HTTPS request for default instant onboarding
b730096 
Depends on the core PR: <chatmail/core#7360>
Using domain name in dcaccount scheme works
similarly to existing scheme,
but no HTTPS request is made
and credentials are generated locally on the client.
@nicodh nicodh force-pushed the link2xt/dcaccount9 branch from 27f45d2 to b730096 Compare November 3, 2025 17:36
WofWca
WofWca approved these changes Nov 3, 2025
View reviewed changes
Copy link
Member

@WofWca WofWca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure exactly what it does, but it's the Core's business. Looks good, the tests have been fixed.

@nicodh nicodh merged commit a36d7e9 into main Nov 3, 2025
11 of 12 checks passed
@nicodh nicodh deleted the link2xt/dcaccount9 branch November 3, 2025 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nicodh nicodh nicodh approved these changes

@WofWca WofWca WofWca approved these changes

Assignees

No one assigned

Labels

new-core involves or requires an core update

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@link2xt @nicodh @WofWca