Open
Conversation
|
Check out the page preview at https://staging.delta.chat/1262/en/verify-downloads |
missytake
approved these changes
Feb 14, 2026
| gpg --import deltachat_certificate.asc.txt | ||
|
|
||
| # Verify signature and file integrity | ||
| gpg --decrypt signature.asc | shasum -a 512 -c - |
Contributor
There was a problem hiding this comment.
Suggested change
| gpg --decrypt signature.asc | shasum -a 512 -c - | |
| gpg --decrypt signature.asc | shasum -a 512 --ignore-missing -c - |
--ignore-missing is missing down here ;)
Comment on lines
+57
to
+61
| gpg: Good signature from "deltachat-signing@merlinux.eu" [unknown] | ||
| gpg: WARNING: This key is not certified with a trusted signature! | ||
| gpg: There is no indication that the signature belongs to the owner. | ||
| Primary key fingerprint: 63CD 1F81 5BA5 6051 8376 999C 626E 26C8 1695 1308 | ||
| <filename>: OK |
Contributor
There was a problem hiding this comment.
Suggested change
| gpg: Good signature from "deltachat-signing@merlinux.eu" [unknown] | |
| gpg: WARNING: This key is not certified with a trusted signature! | |
| gpg: There is no indication that the signature belongs to the owner. | |
| Primary key fingerprint: 63CD 1F81 5BA5 6051 8376 999C 626E 26C8 1695 1308 | |
| <filename>: OK | |
| gpg: Good signature from "deltachat-signing@merlinux.eu" [unknown] | |
| gpg: WARNING: This key is not certified with a trusted signature! | |
| gpg: There is no indication that the signature belongs to the owner. | |
| Primary key fingerprint: 63CD 1F81 5BA5 6051 8376 999C 626E 26C8 1695 1308 | |
| <filename>: OK | |
| shasum: WARNING: 32 lines are improperly formatted |
I also got this warning at the bottom when I checked the signature.asc for 2.35.0; not sure why it didn't appear for you, will future signature.asc files not contain the instructions?
| <filename>: OK | ||
| ``` | ||
|
|
||
| The warning is normal - the signature is valid, but GPG warns because you haven't explicitly trusted the key. **Important:** Verify the fingerprint matches the one shown above. |
Contributor
There was a problem hiding this comment.
Suggested change
| The warning is normal - the signature is valid, but GPG warns because you haven't explicitly trusted the key. **Important:** Verify the fingerprint matches the one shown above. | |
| The warnings are normal - | |
| the signature is valid, but GPG warns because you haven't explicitly trusted the key. | |
| **Important:** Verify the fingerprint matches the one shown above. | |
| The second warning is because of the guidelines in the signature.asc file. |
If the change above is accepted, this should probably be added to. I also used sembr to make the line shorter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One part of resolving deltachat/deltachat-desktop#6030
We need to adapt the signature.asc file that is generated and uploaded by desktop-builder before we can publish this.
The idea is to have the PGP key together with the sha5 checksums in one file so it can be verified in one command
gpg --decrypt signature.asc | shasum -a 512 --ignore-missing -c -sha1 checksums will be removed
The file signature.asc will contain something like