Skip to content

Conversation

@Simon-Laux
Copy link
Member

examples are still missing, but not sure if we absolutely need them.

uri-schemes.md Outdated
```
OPENPGP4FPR:FINGERPRINT#a=ADDR&n=NAME&i=INVITENUMBER&s=AUTH
OPENPGP4FPR:FINGERPRINT#a=ADDR&g=GROUPNAME&x=GROUPID&i=INVITENUMBER&s=AUTH
OPENPGP4FPR:FINGERPRINT#a=ADDR&b=BROADCAST_NAME&x=BROADCAST_ID&i=INVITENUMBER&s=AUTH

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style note: there are no "_" in other param names (e.g. GROUPNAME, INVITENUMBER), but maybe with "_" it reads better

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copied it from the docs in hocuri's core pr, I also noticed this, I agree adding _ everywhere could improve readability

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't matter, any way to write this is understandable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants