Skip to content

Revert to jpg for <YouTube> poster #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
delucis merged 1 commit into from
Apr 10, 2024
Merged

Revert to jpg for <YouTube> poster #117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fifty-balloons-wave.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@astro-community/astro-embed-youtube': patch
---

Revert to `jpg` for `<YouTube>` poster
2 changes: 1 addition & 1 deletion packages/astro-embed-youtube/YouTube.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ const posterFile =
low: 'default',
}[posterQuality] || 'hqdefault';
const posterURL =
poster || `https://i.ytimg.com/vi_webp/${videoid}/${posterFile}.webp`;
poster || `https://i.ytimg.com/vi/${videoid}/${posterFile}.jpg`;
const href = `https://youtube.com/watch?v=${videoid}`;
---

Expand Down
4 changes: 2 additions & 2 deletions tests/astro-embed-youtube.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ test('it should render a lite-youtube element', async () => {
assert.ok(embed);
assert.is(
embed.style['background-image'],
`url('https://i.ytimg.com/vi_webp/${videoid}/hqdefault.webp')`
`url('https://i.ytimg.com/vi/${videoid}/hqdefault.jpg')`
);
// It renders a static link to the video.
const playButton = /** @type {HTMLAnchorElement} */ (
Expand Down Expand Up @@ -84,7 +84,7 @@ test('it can render a lower resolution poster image', async () => {
assert.ok(embed);
assert.is(
embed.style['background-image'],
`url('https://i.ytimg.com/vi_webp/${videoid}/default.webp')`
`url('https://i.ytimg.com/vi/${videoid}/default.jpg')`
);
});

Expand Down