Skip to content

Conversation

@AoSankaku
Copy link

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Dec 25, 2025

⚠️ No Changeset found

Latest commit: c37007d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Dec 25, 2025

Deploy Preview for astro-embed ready!

Name Link
🔨 Latest commit c37007d
🔍 Latest deploy log https://app.netlify.com/projects/astro-embed/deploys/695686633d18cb0008660d55
😎 Deploy Preview https://deploy-preview-226--astro-embed.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Owner

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @AoSankaku. How did you test this? As far as I can tell this PR adds a fetchpriority attribute to the custom element, but this is doesn’t actually do anything?

@AoSankaku
Copy link
Author

@delucis Thanks for your comment, and actually, as you considered, this doesn't do anything and won't remove LCP request discovery warning in pagespeed insignts. So I added actual prefetch element for better fix. This removes LCP request discovery at least on my website.

My personal website uses the exact same patched version of this PR, so you can check it on yourself.

This is the result for non-patched version:
https://pagespeed.web.dev/analysis/https-a5ec86bd-aosankaku-website-2025-pages-dev/k194mwazrb?form_factor=mobile

image

This exists.

And the patched version is this:

https://pagespeed.web.dev/analysis/https-9bb8f79e-aosankaku-website-2025-pages-dev/cq3vfi48ea?form_factor=mobile

"LCP request discovery" warning is gone as you can see.

And the diff is here:

AoSankaku/aosankaku-website-2025@f6c417a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants