Apply relevant updates from TemplateDotNetTool template#105
Apply relevant updates from TemplateDotNetTool template#105Malcolmnixon merged 6 commits intomainfrom
Conversation
Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
|
@copilot Did you actually review the pull-requests of the template? I'm seeing that for example the self-validation printed output contains test descriptions not the test names. Also the requirements don't have semantic IDs. Please re-run by reviewing the pull-requests of the template (as described in the repo-consistency agent) and actually make sure all relevant changes have been applied. |
…tic IDs Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
Fixed in dd67a72. Two changes made:
Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
|
@copilot The lint is reporting issues: The fact there are multiple headings with the same name indicates you didn't correctly update the user guide and instead may have duplicated information. Please compare in detail the self-validation sections of both documents and correct as appropriate. |
Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
Fixed in 1e13ce3. The |
|
@copilot Let's try shortening some of the requirement IDs:
|
Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
Done in 2f5ebfe. All 21 requirement IDs in |
Syncs BuildMark with recent changes in the TemplateDotNetTool template, covering both a full consistency review and specific changes from merged PRs #31–#51.
Description
Functional Fixes
Context.cs,Program.cs):WriteErrorand exception handlers now write toConsole.Errorinstead ofConsole.Out; logStreamWritergetsAutoFlush = truebuild.yaml): All 6 Weasyprint steps gain--pdf-variant pdf/a-3ulint.sh,lint.bat): Addeddotnet format --verify-no-changessteppackage.json: Build tools moved fromdependencies→devDependenciesCode Structure
src csproj: SingleItemGroupsplit into labeledRuntime Dependencies,Build Tool Dependencies, andCode Analysis Dependenciessections;Polyfillsimplified toPrivateAssets="All"onlytest csproj: Added explanatory comments tocoverlet.collectorand analyzerItemGroupsValidation.cs: Output format normalized fromPASSED/FAILED→Passed/Failed; removed separatedisplayNameparameter so console output now uses the test name (e.g.✓ BuildMark_MarkdownReportGeneration - Passed) instead of a human-readable descriptionRequirements
requirements.yaml: All 23 requirement IDs updated to semantic identifiers matching the template pattern:CLI-001–CLI-009→BuildMark-Cmd-*GH-001–GH-003→BuildMark-GH-*RPT-001–RPT-009→BuildMark-Rpt-*VAL-001–VAL-004→BuildMark-Val-*PLT-001–PLT-005→BuildMark-Plt-*Documentation
README.md:### Self-Validation Testspromoted to## Self Validationwith full example output showing test names; CLA sentence added to License sectiondocs/guide/guide.md: Self-Validation section restructured with Validation Report and Validation Tests subsections; removed duplicate# Running Self-Validationtop-level section that had been added in addition to the existing## Self-ValidationsectionCONTRIBUTING.md: FixedAssert.HasCountargument order (collection, count→count, collection); encoding updated toUTF-8(no BOM); added Self-Validation Tests, Requirements Management, and Release Process sectionsAGENTS.md: C# version updated to(latest), lint config reference corrected,UTF-8encoding, Markdown Link Style section addedSECURITY.md: Added Security Disclosure Policy, Third-Party Dependencies, and Additional Resources sectionsDeveloper Experience
build.sh/build.bat: Updated shebang, header comments, modernized error handling.vscode/tasks.json: New file with build/validate/lint VS Code task shortcuts.gitignore: Expanded with standard VS/JetBrains/NuGet/test result/Python patterns.cspell.json: Added ~30 common words from template word listTests Updated
Three tests updated to capture
Console.Errorinstead ofConsole.Outfollowing the stderr change:Context_WriteError_NotSilent_WritesToConsole,Validation_Run_WithUnsupportedResultsFileExtension_ShowsError,Validation_Run_WithInvalidResultsFilePath_ShowsError.Type of Change
Related Issues
Pre-Submission Checklist
Before submitting this pull request, ensure you have completed the following:
Build and Test
dotnet build --configuration Releasedotnet test --configuration Releasedotnet run --project src/DemaConsulting.BuildMark --configuration Release --framework net10.0--no-build -- --validateCode Quality
dotnet format --verify-no-changesQuality Checks
Please run the following checks before submitting:
cspell "**/*.{md,cs}"markdownlint "**/*.md"yamllint '**/*.{yml,yaml}'Testing
Documentation
Additional Notes
Security summary: CodeQL analysis (actions + csharp) found 0 alerts. No vulnerabilities introduced.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.