Skip to content

Fix CodeQL warnings: Replace manual disposal with using declarations #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Malcolmnixon merged 2 commits into from
Feb 8, 2026
Merged

Fix CodeQL warnings: Replace manual disposal with using declarations #57

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a3aecb6
Initial plan
Copilot Feb 8, 2026
09d6075
Refactor ValidationTests to use using statements instead of manual di…
Copilot Feb 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 6 additions & 22 deletions test/DemaConsulting.BuildMark.Tests/ValidationTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,14 +43,12 @@ public void Validation_Run_WithTrxResultsFile_WritesTrxFile()
var trxFile = Path.Combine(tempDir, "results.trx");
var args = new[] { "--validate", "--results", trxFile };

StringWriter? outputWriter = null;
StringWriter? errorWriter = null;
using var outputWriter = new StringWriter();
using var errorWriter = new StringWriter();

try
{
// Capture console output
outputWriter = new StringWriter();
errorWriter = new StringWriter();
Console.SetOut(outputWriter);
Console.SetError(errorWriter);

Expand All @@ -73,9 +71,6 @@ public void Validation_Run_WithTrxResultsFile_WritesTrxFile()
Console.SetOut(standardOutput);
var standardError = new StreamWriter(Console.OpenStandardError()) { AutoFlush = true };
Console.SetError(standardError);

outputWriter?.Dispose();
errorWriter?.Dispose();
}
}
finally
Expand Down Expand Up @@ -103,14 +98,12 @@ public void Validation_Run_WithXmlResultsFile_WritesJUnitFile()
var xmlFile = Path.Combine(tempDir, "results.xml");
var args = new[] { "--validate", "--results", xmlFile };

StringWriter? outputWriter = null;
StringWriter? errorWriter = null;
using var outputWriter = new StringWriter();
using var errorWriter = new StringWriter();

try
{
// Capture console output
outputWriter = new StringWriter();
errorWriter = new StringWriter();
Console.SetOut(outputWriter);
Console.SetError(errorWriter);

Expand All @@ -133,9 +126,6 @@ public void Validation_Run_WithXmlResultsFile_WritesJUnitFile()
Console.SetOut(standardOutput);
var standardError = new StreamWriter(Console.OpenStandardError()) { AutoFlush = true };
Console.SetError(standardError);

outputWriter?.Dispose();
errorWriter?.Dispose();
}
}
finally
Expand Down Expand Up @@ -163,12 +153,11 @@ public void Validation_Run_WithUnsupportedResultsFileExtension_ShowsError()
var unsupportedFile = Path.Combine(tempDir, "results.json");
var args = new[] { "--validate", "--results", unsupportedFile };

StringWriter? outputWriter = null;
using var outputWriter = new StringWriter();

try
{
// Capture console output
outputWriter = new StringWriter();
Console.SetOut(outputWriter);

// Act
Expand All @@ -184,8 +173,6 @@ public void Validation_Run_WithUnsupportedResultsFileExtension_ShowsError()
// Restore console output
var standardOutput = new StreamWriter(Console.OpenStandardOutput()) { AutoFlush = true };
Console.SetOut(standardOutput);

outputWriter?.Dispose();
}
}
finally
Expand All @@ -208,12 +195,11 @@ public void Validation_Run_WithInvalidResultsFilePath_ShowsError()
var invalidPath = Path.Combine("/invalid_path_that_does_not_exist_12345678", "results.trx");
var args = new[] { "--validate", "--results", invalidPath };

StringWriter? outputWriter = null;
using var outputWriter = new StringWriter();

try
{
// Capture console output
outputWriter = new StringWriter();
Console.SetOut(outputWriter);

// Act
Expand All @@ -229,8 +215,6 @@ public void Validation_Run_WithInvalidResultsFilePath_ShowsError()
// Restore console output
var standardOutput = new StreamWriter(Console.OpenStandardOutput()) { AutoFlush = true };
Console.SetOut(standardOutput);

outputWriter?.Dispose();
}
}
}