Migrate GitHubGraphQLClient to GraphQL.Client library with pagination support#77
Merged
Malcolmnixon merged 6 commits intomainfrom Feb 17, 2026
Merged
Conversation
Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Switch GitHubGraphQLClient to use GraphQL.Client
Migrate GitHubGraphQLClient to GraphQL.Client library
Feb 16, 2026
Malcolmnixon
requested changes
Feb 16, 2026
src/DemaConsulting.BuildMark/RepoConnectors/GitHub/GitHubGraphQLTypes.cs
Outdated
Show resolved
Hide resolved
src/DemaConsulting.BuildMark/RepoConnectors/GitHub/GitHubGraphQLClient.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
Migrate GitHubGraphQLClient to GraphQL.Client library
Migrate GitHubGraphQLClient to GraphQL.Client library with pagination support
Feb 16, 2026
Malcolmnixon
requested changes
Feb 16, 2026
test/DemaConsulting.BuildMark.Tests/GitHubGraphQLClientTests.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Malcolmnixon
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Refactored
GitHubGraphQLClientfrom rawHttpClientto useGraphQL.Clientlibrary for type-safe GraphQL query execution. This standardizes GraphQL interactions and prepares the codebase for eventual Octokit retirement.Key Changes:
GitHubGraphQLClienttoRepoConnectors/GitHub/subfolderGitHubGraphQLClientTests.cstotest/DemaConsulting.BuildMark.Tests/RepoConnectors/GitHub/subfolder to mirror production code structureGraphQL.Client(v6.1.0) andGraphQL.Client.Serializer.SystemTextJson(v6.1.0)GitHubGraphQLTypes.csGraphQLHttpClient.SendQueryAsync<T>()HttpClientfor test mockingImplementation Details:
PageInforecord type for pagination across future GraphQL querieshasNextPageandendCursorint?forIssueNode.Numberto handle malformed API responses.Where(n => n.Number.HasValue)Type of Change
Related Issues
Pre-Submission Checklist
Before submitting this pull request, ensure you have completed the following:
Build and Test
dotnet build --configuration Releasedotnet test --configuration ReleaseCode Quality
dotnet format --verify-no-changesQuality Checks
Please run the following checks before submitting:
cspell "**/*.{md,cs}"markdownlint "**/*.md"yamllint '**/*.{yml,yaml}'Testing
Documentation
Additional Notes
All 8
GitHubGraphQLClientunit tests pass, including a new test for pagination scenarios. CodeQL scan shows zero security alerts. Dependencies verified against GitHub Advisory Database with no vulnerabilities found.The pagination implementation is designed to be reusable for future GraphQL queries, as the
PageInforecord type can be used with any paginated GraphQL response.Test files are now organized in a subfolder structure (
test/DemaConsulting.BuildMark.Tests/RepoConnectors/GitHub/) that mirrors the production code organization, improving maintainability and discoverability.Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.