Add cross-platform unit tests with MSTest framework#21
Merged
Malcolmnixon merged 7 commits intomainfrom Dec 25, 2025
Merged
Conversation
Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add cross-platform unit tests for DotnetToolWrapper
Add cross-platform unit tests with MSTest framework
Dec 25, 2025
Malcolmnixon
requested changes
Dec 25, 2025
test/DemaConsulting.DotnetToolWrapper.Tests/DotnetToolWrapperTests.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
Malcolmnixon
requested changes
Dec 25, 2025
| /// <returns>Shell program name</returns> | ||
| private static string GetShellProgram() | ||
| { | ||
| return RuntimeInformation.IsOSPlatform(OSPlatform.Windows) ? "cmd.exe" : "/bin/sh"; |
Contributor
There was a problem hiding this comment.
"cmd.exe" is not a complete path to the windows shell. Consider replacing this with using environment variables or some other more reliable way to get an absolute path to the shell program.
Contributor
There was a problem hiding this comment.
@copilot Please try fixing this again - you encountered a failure last time because you got stuck in a loop forever failing to read CI workflow logs - do not try to read them when working on this.
Contributor
Author
There was a problem hiding this comment.
Fixed in commit 81f9cce. Changed GetShellProgram() to use the COMSPEC environment variable on Windows, which provides the full path to cmd.exe (typically C:\Windows\System32\cmd.exe), instead of just "cmd.exe".
Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
Malcolmnixon
approved these changes
Dec 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation Plan for Cross-Platform Unit Tests
/test/DemaConsulting.DotnetToolWrapper.TestsdirectoryRunner.cshelper classOriginal prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.