-
Notifications
You must be signed in to change notification settings - Fork 0
Apply template updates: Polyfill, netstandard2.0, and net481 Windows test evidence #120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
b8fcef7
Initial plan
Copilot 7dd264b
Apply TemplateDotNetLibrary updates: Polyfill, LangVersion=latest, ne…
Copilot 5971af5
Add net481 Windows test target and update REQ-PLAT-004 to use net481 …
Copilot 076adf0
Simplify System.Text.Json to single version and restore lowercase Gen…
Copilot 7a8e86f
Restore GenerateDocumentationFile to lowercase true in library project
Copilot d4430a2
Replace HashCodePolyfill with Microsoft.Bcl.HashCode 6.0.0; fix spell…
Copilot b7119eb
Fix net481 build: guard ReplaceLineEndings behind NET6_0_OR_GREATER i…
Copilot dadaa1b
Use library's Polyfill via global using Polyfills; instead of #if gua…
Copilot 2e2bab3
Fix ArgumentException message assertions to be portable across .NET F…
Copilot 63da661
Replace Assert.IsTrue(x.StartsWith) antipattern with Assert.StartsWith
Copilot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,100 @@ | ||
| // Copyright(c) 2024 DEMA Consulting | ||
| // | ||
| // Permission is hereby granted, free of charge, to any person obtaining a copy | ||
| // of this software and associated documentation files (the "Software"), to deal | ||
| // in the Software without restriction, including without limitation the rights | ||
| // to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
| // copies of the Software, and to permit persons to whom the Software is | ||
| // furnished to do so, subject to the following conditions: | ||
| // | ||
| // The above copyright notice and this permission notice shall be included in all | ||
| // copies or substantial portions of the Software. | ||
| // | ||
| // THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
| // IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
| // FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
| // AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
| // LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
| // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE | ||
| // SOFTWARE. | ||
|
|
||
| #if NETSTANDARD2_0 | ||
|
|
||
| // Provide a minimal HashCode.Combine polyfill for netstandard2.0, which does not | ||
| // have System.HashCode. The implementation uses prime-based accumulation to | ||
| // produce reasonably well-distributed hash codes from multiple values, matching | ||
| // the public API surface used in this library. | ||
| namespace System; | ||
|
|
||
| /// <summary> | ||
| /// Polyfill for <c>System.HashCode</c> on netstandard2.0 targets. | ||
| /// </summary> | ||
| /// <remarks> | ||
| /// System.HashCode was introduced in .NET Core 2.1 / netstandard2.1 and is not | ||
| /// available in netstandard2.0. This internal struct provides the Combine overloads | ||
| /// used by this library so that no conditional compilation is needed in calling code. | ||
| /// </remarks> | ||
| internal struct HashCode | ||
| { | ||
| /// <summary> | ||
| /// Combines two values into a hash code using prime-based accumulation. | ||
| /// </summary> | ||
| /// <typeparam name="T1">Type of the first value</typeparam> | ||
| /// <typeparam name="T2">Type of the second value</typeparam> | ||
| /// <param name="value1">First value</param> | ||
| /// <param name="value2">Second value</param> | ||
| /// <returns>Combined hash code</returns> | ||
| public static int Combine<T1, T2>(T1 value1, T2 value2) | ||
| { | ||
| // Accumulate hash codes using a prime multiplier to reduce collisions | ||
| var hash = 17; | ||
| hash = hash * 31 + (value1?.GetHashCode() ?? 0); | ||
| hash = hash * 31 + (value2?.GetHashCode() ?? 0); | ||
| return hash; | ||
| } | ||
|
|
||
| /// <summary> | ||
| /// Combines three values into a hash code using prime-based accumulation. | ||
| /// </summary> | ||
| /// <typeparam name="T1">Type of the first value</typeparam> | ||
| /// <typeparam name="T2">Type of the second value</typeparam> | ||
| /// <typeparam name="T3">Type of the third value</typeparam> | ||
| /// <param name="value1">First value</param> | ||
| /// <param name="value2">Second value</param> | ||
| /// <param name="value3">Third value</param> | ||
| /// <returns>Combined hash code</returns> | ||
| public static int Combine<T1, T2, T3>(T1 value1, T2 value2, T3 value3) | ||
| { | ||
| // Accumulate hash codes using a prime multiplier to reduce collisions | ||
| var hash = 17; | ||
| hash = hash * 31 + (value1?.GetHashCode() ?? 0); | ||
| hash = hash * 31 + (value2?.GetHashCode() ?? 0); | ||
| hash = hash * 31 + (value3?.GetHashCode() ?? 0); | ||
| return hash; | ||
| } | ||
|
|
||
| /// <summary> | ||
| /// Combines four values into a hash code using prime-based accumulation. | ||
| /// </summary> | ||
| /// <typeparam name="T1">Type of the first value</typeparam> | ||
| /// <typeparam name="T2">Type of the second value</typeparam> | ||
| /// <typeparam name="T3">Type of the third value</typeparam> | ||
| /// <typeparam name="T4">Type of the fourth value</typeparam> | ||
| /// <param name="value1">First value</param> | ||
| /// <param name="value2">Second value</param> | ||
| /// <param name="value3">Third value</param> | ||
| /// <param name="value4">Fourth value</param> | ||
| /// <returns>Combined hash code</returns> | ||
| public static int Combine<T1, T2, T3, T4>(T1 value1, T2 value2, T3 value3, T4 value4) | ||
| { | ||
| // Accumulate hash codes using a prime multiplier to reduce collisions | ||
| var hash = 17; | ||
| hash = hash * 31 + (value1?.GetHashCode() ?? 0); | ||
| hash = hash * 31 + (value2?.GetHashCode() ?? 0); | ||
| hash = hash * 31 + (value3?.GetHashCode() ?? 0); | ||
| hash = hash * 31 + (value4?.GetHashCode() ?? 0); | ||
| return hash; | ||
| } | ||
| } | ||
|
|
||
| #endif |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.