Port improvements from TemplateDotNetLibrary template#32
Conversation
|
@copilot Please consider the test-developer agent and see if there's anything suitable for updating. |
…, buildmark version, test csproj structure Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
- Remove redundant InternalsVisibleTo from test AssemblyInfo.cs - Add consistent AAA (Arrange/Act/Assert) comments to all test methods - Matches patterns from TemplateDotNetLibrary and existing PathHelpersTests.cs
…sibleTo from test AssemblyInfo Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
Used the test-developer agent to evaluate test files. Made two improvements in commits f933999 and 7be4af7:
All 32 tests pass, format check passes. |
|
@copilot I think you RAN the test-developer agent to modify the code. I actually want you to review the test-developer agent MD file against the version in https://github.com/demaconsulting/TemplateDotNetLibrary/blob/main/.github/agents/test-developer.md and see if this one should be updated. |
…rary template Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
Compared |
* Initial plan * Apply changes from TemplateDotNetLibrary PRs #30, #31, #32 Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
Pull Request
Description
Sync shared infrastructure patterns from TemplateDotNetLibrary into this repo. Differences specific to tool-vs-library (integration tests, self-validation, Context/Program classes) are intentionally preserved.
.editorconfig: Addend_of_line = lfto[*]section.gitignore: Addpackage-lock.jsonto Node.js section.config/dotnet-tools.json: Bumpbuildmark0.2.0→0.3.0.csproj: Reorganize to match library template — section comments (<!-- Build Configuration -->,<!-- Code Quality Configuration -->,<!-- Test Framework Dependencies -->,<!-- Code Analysis Dependencies -->,<!-- Project References -->), separate ItemGroups for test framework vs code analysis packages, reorder PropertyGroup entries (build config → packaging → quality)InternalsVisibleToattribute (already handled by main.csproj's<InternalsVisibleTo>element, matching library template pattern)// Arrange,// Act,// Assertcomments to all test methods in ContextTests.cs, ProgramTests.cs, and IntegrationTests.cs (matching existing PathHelpersTests.cs pattern and library template convention).github/agents/test-developer.md: Add MSTest V4 Best Practices section from library template (anti-patterns for catch-block assertions, IsTrue/IsFalse equality checks, non-public test classes, and collection count assertions)Type of Change
Related Issues
Pre-Submission Checklist
Before submitting this pull request, ensure you have completed the following:
Build and Test
dotnet build --configuration Releasedotnet test --configuration Releasedotnet run --project src/DemaConsulting.TemplateDotNetTool --configuration Release --framework net10.0--no-build -- --validateCode Quality
dotnet format --verify-no-changesQuality Checks
Please run the following checks before submitting:
cspell "**/*.{md,cs}"markdownlint "**/*.md"yamllint .Testing
Documentation
Additional Notes
No functional or behavioral changes. All 32 existing tests pass unchanged. CodeQL reports 0 alerts.
The test-developer agent MD file was reviewed against the Library template version and updated with the missing MSTest V4 Best Practices section. Tool-specific differences (integration test references, self-validation warnings) are intentionally preserved.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.