Skip to content

Group package dependencies into labeled ItemGroup sections#47

Merged
Malcolmnixon merged 2 commits intomainfrom
copilot/group-package-dependencies
Mar 1, 2026
Merged

Group package dependencies into labeled ItemGroup sections#47
Malcolmnixon merged 2 commits intomainfrom
copilot/group-package-dependencies

Conversation

Copy link
Contributor

Copilot AI commented Mar 1, 2026

Pull Request

Description

Reorganizes PackageReference entries in both .csproj files into separate, labeled ItemGroup sections — mirroring the pattern established in TemplateDotNetLibrary.

DemaConsulting.TemplateDotNetTool.csproj — splits one mixed ItemGroup into three:

<!-- Runtime Dependencies -->
<ItemGroup>
  <PackageReference Include="DemaConsulting.TestResults" Version="1.5.0" />
</ItemGroup>

<!-- Build Tool Dependencies -->
<ItemGroup>
  <PackageReference Include="Microsoft.Sbom.Targets" Version="4.1.5" PrivateAssets="All" />
  <PackageReference Include="Microsoft.SourceLink.GitHub" Version="10.0.103" PrivateAssets="All" />
  <PackageReference Include="Polyfill" Version="9.12.0" PrivateAssets="All" />
</ItemGroup>

<!-- Code Analysis Dependencies -->
<ItemGroup>
  <!-- Analyzer packages use child-element form ... -->
  <PackageReference Include="Microsoft.CodeAnalysis.NetAnalyzers" Version="10.0.103">...</PackageReference>
  <PackageReference Include="SonarAnalyzer.CSharp" Version="10.20.0.135146">...</PackageReference>
</ItemGroup>

Polyfill moves from the analyzer group to Build Tool Dependencies using the simplified PrivateAssets="All" inline form (consistent with library).

DemaConsulting.TemplateDotNetTool.Tests.csproj — structure already grouped; adds descriptive inline comments to Test Framework Dependencies and Code Analysis Dependencies groups explaining the child-element attribute pattern, matching the library reference.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Code quality improvement

Related Issues

Pre-Submission Checklist

Before submitting this pull request, ensure you have completed the following:

Build and Test

  • Code builds successfully: dotnet build --configuration Release
  • All unit tests pass: dotnet test --configuration Release
  • Self-validation tests pass:
    dotnet run --project src/DemaConsulting.TemplateDotNetTool --configuration Release --framework net10.0
    --no-build -- --validate
  • Code produces zero warnings

Code Quality

  • Code formatting is correct: dotnet format --verify-no-changes
  • New code has appropriate XML documentation comments
  • Static analyzer warnings have been addressed

Quality Checks

Please run the following checks before submitting:

  • Spell checker passes: cspell "**/*.{md,cs}"
  • Markdown linter passes: markdownlint "**/*.md"
  • YAML linter passes: yamllint .

Testing

  • Added unit tests for new functionality
  • Updated existing tests if behavior changed
  • All tests follow the AAA (Arrange, Act, Assert) pattern
  • Test coverage is maintained or improved

Documentation

  • Updated README.md (if applicable)
  • Updated ARCHITECTURE.md (if applicable)
  • Added code examples for new features (if applicable)
  • Updated requirements.yaml (if applicable)

Additional Notes

No functional behavior changes — this is a project file organization improvement only.


🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
Copilot AI changed the title [WIP] Update package dependencies into separate ItemGroup sections Group package dependencies into labeled ItemGroup sections Mar 1, 2026
@Malcolmnixon Malcolmnixon marked this pull request as ready for review March 1, 2026 01:36
@Malcolmnixon Malcolmnixon merged commit e629bc8 into main Mar 1, 2026
11 checks passed
@Malcolmnixon Malcolmnixon deleted the copilot/group-package-dependencies branch March 1, 2026 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants