feat: migrate to @icp-sdk/core (breaking changes)
#3471
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o update @dfinity dependencies more easily
lastmjs
force-pushed
the
update_dfinity
branch
from
3ac1f9b to
1586d7e
Compare
lastmjs
changed the title
feat: migrate to @icp-sdk/core
|
@codex review |
There was a problem hiding this comment.
Pull Request Overview
This PR migrates from the deprecated @dfinity packages to the new @icp-sdk/core package for IC blockchain development. This is a major dependency migration that updates imports across the entire codebase while maintaining the same functionality.
- Consolidates multiple
@dfinitypackages (@dfinity/agent,@dfinity/candid,@dfinity/principal, etc.) into the single@icp-sdk/corepackage - Updates all import statements throughout the codebase to use the new package structure
- Modifies the candid generation process to automatically replace
@dfinity/imports with@icp-sdk/core/imports
Reviewed Changes
Copilot reviewed 196 out of 226 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Updates main dependency from @dfinity/agent to @icp-sdk/core and removes separate dfinity packages |
| src/stable/build/commands/generate/index.ts | Adds automatic replacement of @dfinity/ with @icp-sdk/core/ in generated code |
| src/stable/build/commands/new.ts | Removes legacy dfinity identity dependency from new project template |
| src/stable/lib/*.ts | Updates all core library imports to use @icp-sdk/core subpaths |
| src/experimental/*.ts | Updates experimental feature imports to new package structure |
| examples/*/package.json | Updates example project dependencies and removes legacy dfinity packages |
| .github/workflows/*.yml | Updates CI workflow dependency installation commands |
Files not reviewed (27)
- examples/experimental/demo/hello_world_http_server/package-lock.json: Language not supported
- examples/experimental/test/end_to_end/http_server/apollo_server/package-lock.json: Language not supported
- examples/experimental/test/end_to_end/http_server/audio_and_video/package-lock.json: Language not supported
- examples/experimental/test/end_to_end/http_server/autoreload/package-lock.json: Language not supported
- examples/experimental/test/end_to_end/http_server/ethers/package-lock.json: Language not supported
- examples/experimental/test/end_to_end/http_server/ethers_base/package-lock.json: Language not supported
- examples/experimental/test/end_to_end/http_server/express/package-lock.json: Language not supported
- examples/experimental/test/end_to_end/http_server/fetch_ic/package-lock.json: Language not supported
- examples/experimental/test/end_to_end/http_server/file_protocol/package-lock.json: Language not supported
- examples/experimental/test/end_to_end/http_server/fs/package-lock.json: Language not supported
- examples/experimental/test/end_to_end/http_server/http_outcall_fetch/package-lock.json: Language not supported
- examples/experimental/test/end_to_end/http_server/hybrid_canister/package-lock.json: Language not supported
- examples/experimental/test/end_to_end/http_server/ic_evm_rpc/package-lock.json: Language not supported
- examples/experimental/test/end_to_end/http_server/internet_identity/package-lock.json: Language not supported
- examples/experimental/test/end_to_end/http_server/large_files/package-lock.json: Language not supported
- examples/experimental/test/end_to_end/http_server/multi_deploy/package-lock.json: Language not supported
- examples/experimental/test/end_to_end/http_server/nest/package-lock.json: Language not supported
- examples/experimental/test/end_to_end/http_server/tfjs/package-lock.json: Language not supported
- examples/experimental/test/end_to_end/http_server/web_assembly/package-lock.json: Language not supported
- examples/package-lock.json: Language not supported
- examples/stable/test/end_to_end/candid_rpc/motoko_examples/cert-var/package-lock.json: Language not supported
- examples/stable/test/end_to_end/candid_rpc/motoko_examples/whoami/package-lock.json: Language not supported
- examples/stable/test/property/candid_rpc/canister_methods/inspect_message/package-lock.json: Language not supported
- examples/stable/test/property/ic_api/caller/package-lock.json: Language not supported
- examples/stable/test/property/ic_api/certified_data/package-lock.json: Language not supported
- examples/stable/test/property/ic_api/is_controller/package-lock.json: Language not supported
- package-lock.json: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting
lastmjs
changed the title
feat: migrate to @icp-sdk/corefeat: migrate to @icp-sdk/core (breaking changes)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor
feat:prefix used if functionality should be included in theFeaturessection of the release notesReviewer
feat:prefix used if functionality should be included in theFeaturessection of the release notesFeatures
@icp-sdk/core, removing all uses of@dfinity/*packages besides@dfinity/auth-client.Breaking Changes
npx azle generatecommand now imports from@icp-sdk/coreinstead of@dfinity/*. You may need to install@icp-sdk/coreto use the generated code.azle-experimental-deps:npm install https://github.com/demergent-labs/azle-experimental-deps#0afef5f615bc77fb303c5e95211daf6d7bb73dd3