feat: rename deployment and update configuration for import-plenary-m…#681
Merged
feat: rename deployment and update configuration for import-plenary-m…#681
Conversation
…inutes Refactor the deployment name to 'import-plenary-minutes-config' and adjust the manifest templates. This change improves clarity and maintains consistency in the configuration structure.
There was a problem hiding this comment.
Pull Request Overview
This pull request refactors the plenary minutes import job by splitting the deployment configuration into separate resources and improving the import script's scalability. The changes enhance maintainability by separating configuration concerns and making the import process more flexible.
- Splits deployment into separate ConfigMap and ad-hoc job resources for better separation of concerns
- Updates import script to iterate over all periods dynamically instead of hardcoded calls
- Adds logging to track which period is being imported for better transparency
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| services/cron-jobs/import-plenary-minutes/src/index.ts | Adds period logging and refactors to iterate over all periods dynamically |
| services/cron-jobs/import-plenary-minutes/garden.yml | Splits deployment into ConfigMap and Run resources, updates container configuration |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request restructures the deployment configuration for the plenary minutes import job and improves the import script for better maintainability and clarity. The most important changes are grouped below:
Deployment Configuration Refactor:
garden.ymldeployment into two separate resources: aConfigMapdeploy (import-plenary-minutes-config) and an ad-hoc import job (import-plenary-minutes), improving separation of concerns and maintainability.ConfigMapand set the containerimagePullPolicytoIfNotPresent, ensuring correct configuration and more efficient image usage.Import Script Improvements:
periodsarray instead of callingstartfor each period explicitly, making the code more scalable and easier to maintain.fixes helper texts (admin) are missing #680