Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR modernizes Garden configuration for cron jobs by migrating from manifest-based deployments to ad-hoc Kubernetes pod runs, centralizing environment variable management, and adding a new import job for conference week details.
Key Changes:
- Migrated
crawlerandsync-proceduresfrom manifest-basedDeployactions toRunactions with inline pod specifications - Removed ConfigMap and Secret dependencies in favor of direct environment variable injection with defaults
- Added new
import-conference-week-detailscron job with build and run actions
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
services/cron-jobs/sync-procedures/manifests/ConfigMap.yaml |
Removed legacy ConfigMap manifest as environment variables are now injected directly |
services/cron-jobs/sync-procedures/garden.yml |
Converted from Deploy to Run action with inline pod spec and environment variables |
services/cron-jobs/import-conference-week-details/manifests/secret.yaml |
Added Secret manifest for DIP API token from varfiles |
services/cron-jobs/import-conference-week-details/garden.yml |
Created new Run action for conference week details import with optional varfiles |
services/cron-jobs/crawler/garden.yml |
Removed crawler-config Deploy dependency and replaced envFrom with explicit env variables |
democracy/desktop/garden.yml |
Added missing APP_HOST and APP_API_URL environment variables |
services/cron-jobs/import-conference-week-details/manifests/secret.yaml
Outdated
Show resolved
Hide resolved
d19a7f1 to
96e7869
Compare
- [import-conference-week-details] add garden files - [crawler] use env instead of config file - [desktoop] add missing env vars - [sync-procedures] refactor to run instead of deploy Signed-off-by: Manuel Ruck <git@manuelruck.de>
96e7869 to
80d1982
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the configuration and deployment setup for several cron job services, moving from Kubernetes
Deployactions and ConfigMaps to ad-hocRunactions using Kubernetes pods with explicit environment variable definitions. This change streamlines the configuration process, improves clarity, and enhances control over environment variables for each job. Additionally, a new import job for conference week details is introduced.Refactoring deployment and configuration for cron jobs
crawlerandsync-proceduresservices from KubernetesDeployactions using ConfigMaps and manifest templates to directRunactions with Kubernetes pods, simplifying the deployment and configuration process. [1] [2]Environment variable handling improvements
democracy-desktopcontainer to setAPP_HOSTandAPP_API_URLenvironment variables, ensuring correct API connectivity.New import job
import-conference-week-detailscron job with its own build and run actions, including environment variable configuration and dependency management.