Skip to content

chore(garden): improve garden configs#706

Merged
ManAnRuck merged 1 commit intomasterfrom
chore/garden
Oct 28, 2025
Merged

chore(garden): improve garden configs#706
ManAnRuck merged 1 commit intomasterfrom
chore/garden

Conversation

@ManAnRuck
Copy link
Member

@ManAnRuck ManAnRuck commented Oct 28, 2025

  • [import-conference-week-details] add garden files
  • [crawler] use env instead of config file
  • [desktoop] add missing env vars
  • [sync-procedures] refactor to run instead of deploy

This pull request refactors the configuration and deployment setup for several cron job services, moving from Kubernetes Deploy actions and ConfigMaps to ad-hoc Run actions using Kubernetes pods with explicit environment variable definitions. This change streamlines the configuration process, improves clarity, and enhances control over environment variables for each job. Additionally, a new import job for conference week details is introduced.

Refactoring deployment and configuration for cron jobs

  • Migrated crawler and sync-procedures services from Kubernetes Deploy actions using ConfigMaps and manifest templates to direct Run actions with Kubernetes pods, simplifying the deployment and configuration process. [1] [2]
  • Removed the use of external ConfigMaps and secrets for environment variables, now setting all required environment variables directly in the pod specification for each job. [1] [2] [3]

Environment variable handling improvements

  • Added explicit environment variable definitions for each container, including support for optional variables and defaults, improving clarity and flexibility. [1] [2] [3]
  • Updated democracy-desktop container to set APP_HOST and APP_API_URL environment variables, ensuring correct API connectivity.

New import job

  • Added a new import-conference-week-details cron job with its own build and run actions, including environment variable configuration and dependency management.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR modernizes Garden configuration for cron jobs by migrating from manifest-based deployments to ad-hoc Kubernetes pod runs, centralizing environment variable management, and adding a new import job for conference week details.

Key Changes:

  • Migrated crawler and sync-procedures from manifest-based Deploy actions to Run actions with inline pod specifications
  • Removed ConfigMap and Secret dependencies in favor of direct environment variable injection with defaults
  • Added new import-conference-week-details cron job with build and run actions

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
services/cron-jobs/sync-procedures/manifests/ConfigMap.yaml Removed legacy ConfigMap manifest as environment variables are now injected directly
services/cron-jobs/sync-procedures/garden.yml Converted from Deploy to Run action with inline pod spec and environment variables
services/cron-jobs/import-conference-week-details/manifests/secret.yaml Added Secret manifest for DIP API token from varfiles
services/cron-jobs/import-conference-week-details/garden.yml Created new Run action for conference week details import with optional varfiles
services/cron-jobs/crawler/garden.yml Removed crawler-config Deploy dependency and replaced envFrom with explicit env variables
democracy/desktop/garden.yml Added missing APP_HOST and APP_API_URL environment variables

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

- [import-conference-week-details] add garden files
- [crawler] use env instead of config file
- [desktoop] add missing env vars
- [sync-procedures] refactor to run instead of deploy

Signed-off-by: Manuel Ruck <git@manuelruck.de>
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

@ManAnRuck ManAnRuck merged commit 28be330 into master Oct 28, 2025
7 checks passed
@ManAnRuck ManAnRuck deleted the chore/garden branch October 28, 2025 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants