Exclude thumbnails folder from package#12
Merged
demurgos merged 1 commit intodemurgos:mainfrom Jan 3, 2025
Merged
Conversation
demurgos
force-pushed
the
exclude-thumbnails
branch
from
e941b6e to
dbf3912
Compare
demurgos
added a commit
that referenced
this pull request
Jan 3, 2025
- **[Feature]** Detect COSMIC Epoch. ([@netraptor](https://github.com/netraptor), [#13](#13)) - **[Fix]** Fix spelling when matching `GNOME-Classic`. ([@bash](https://github.com/bash), [#11](#11)) - **[Fix]** Remove thumbnails from Cargo package, for faster downloads. ([@bbb651](https://github.com/bbb651), [#12](#12))
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reduces the folder significantly, by 1.4MB (~90% reduction). Thankfully crates.io makes links in the README relative to the repository (e.g.
https://github.com/demurgos/detect-desktop-environment/raw/HEAD/././thumbnails/cinnamon.png) so it shouldn't break it.Maybe
CHANGELOG.mdshould be excluded too, I've seen some other projects do so (e.g. Tauri), but it's small enough that it's probably fine to keep it there.