Conversation
Owner
|
Thank you for the PR. While looking at the changes I also noticed that there was no env var configured for the legacy cosmic DE. I'll open an issue to track it, but it may not be high priority. Your changes look good, I'll rebase, squash and add a CHANGELOG entry; then I'll release it as version |
demurgos
added a commit
that referenced
this pull request
Jan 3, 2025
- **[Feature]** Detect COSMIC Epoch. ([@netraptor](https://github.com/netraptor), [#13](#13)) - **[Fix]** Fix spelling when matching `GNOME-Classic`. ([@bash](https://github.com/bash), [#11](#11)) - **[Fix]** Remove thumbnails from Cargo package, for faster downloads. ([@bbb651](https://github.com/bbb651), [#12](#12))
This was referenced Jan 3, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding a check for COSMIC Epoch.
On the current alpha for COSMIC Epoch, XDG_CURRENT_DESKTOP appears to be set to
COSMIC, vs the legacy GNOME-based version of COSMIC where it appears to be set topop:GNOME(on Pop!_OS at least). Since this is still an alpha, I'm not sure if that will change in the future, but this should work for now I think.Also, unless I missed it, I didn't see an actual check for the legacy GNOME-based COSMIC. I didn't bother adding one since I'm not sure if it's different enough from base GNOME to warrant a separate check, but I thought I'd at least mention it.
EDIT: Apparently COSMIC is in the Freedesktop.org registered table, so I'm assuming this shouldn't change in the near future.