Skip to content

Conversation

@TheAngryByrd
Copy link
Collaborator

@TheAngryByrd TheAngryByrd commented Dec 7, 2024

Proposed Changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

What types of changes does your code introduce to FsToolkit.ErrorHandling?
Put an x in the boxes that apply and remove ones that don't apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • Build and tests pass locally
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

TheAngryByrd and others added 15 commits December 7, 2024 13:28
* remove Ply and update to FSharp 6

* Cleanup dependencies

* Fix fsharp.core warning

* Don't build so much
* use  Microsoft.Bcl.AsyncInterfaces

* Updated IcedTasks to 0.11.0

* Fix for fable
* net8 tfm

* Update README
* Missed this in net8 additions

* Fix overload resolution issues in Core

* Fix overload resolution issues in Tasks/Hopac

* Fix overload resolution issues in CancellableTaskResult

* WIP: TaskValidtionCE

* Wip merge sources

* Fix MergeSources for CTValidation

* cleanup

* Ensure IAsyncDisposable tests

* ignore nuget stuff
* Roll on '24

* refactor(Seq.sequenceResultM)!: Change Ok to Array

* docs: sequenceResultM

* feat(Seq): sequenceResultA

* f sequenceResultM docs

* Supress compile error

* Fix proposed version
* Remove MergeSources from resultCE

* Remove MergeSources from AsyncResult

* Remove MergeSources from ResultOption

* Fixup resultOption docs

* Remove MergeSources from OptionCE

* Remove MergeSources from ValueOptionCE

* remove MergeSources Option/ValueOption
@TheAngryByrd TheAngryByrd marked this pull request as ready for review December 7, 2024 20:56
@TheAngryByrd TheAngryByrd merged commit 83a5383 into master Dec 7, 2024
33 checks passed
@TheAngryByrd TheAngryByrd mentioned this pull request Dec 7, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants