changed the visual representation of the battery level#8
Open
csperle wants to merge 2 commits intodennisreimann:masterfrom
Open
changed the visual representation of the battery level#8csperle wants to merge 2 commits intodennisreimann:masterfrom
csperle wants to merge 2 commits intodennisreimann:masterfrom
Conversation
Owner
|
To be honest I don't want to overcomplicate this part. I'm running the Kindle plugged in all the time, because my battery is too weak to run it for two days straight and other peoples experience seems to be along the same line. |
Author
|
Good point. I have enhanced the feature to only show the battery level if not plugged in. But no worries for not pulling. I can rebase the feature when the development moves on to still show it on my kindle:) |
Owner
|
I'll leave this open for others to maybe chime in – but as you said, it's easy to apply this on a personal basis. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please take a look on this commit that changes the way the battery level is shown. The problem with the old indicator was, that it should show the battery level (if < 25) as a number in percent. The problem: the kindle 4 can not show the percent sign. This looked strange. See for more details:
https://www.mobileread.com/forums/showthread.php?t=278982
I wanted to change that into a visual representation drawing two rectangles on the screen, showing how full the battery is. Unfortunatelly also this command does not work on a kindle 4 (argh!). See:
https://wiki.mobileread.com/wiki/Eips
Now I am using characters showing a somewhat visual representation (enriched with the number):
|----25->==|
Only pull it, if you like it.
Because I only want to call the drawing command once, I used this odd looking switch-case structure instead of a fancy loop to generate the characters.