WIP: Introduce new IOCTLs and their structs#9
Draft
casKd-dev wants to merge 2 commits intodennwc:masterfrom
Draft
WIP: Introduce new IOCTLs and their structs#9casKd-dev wants to merge 2 commits intodennwc:masterfrom
casKd-dev wants to merge 2 commits intodennwc:masterfrom
Conversation
dennwc
reviewed
Sep 27, 2024
Owner
dennwc
left a comment
dennwc
left a comment
There was a problem hiding this comment.
Looks good so far! Anything else you want to add here?
| func (arg *btrfs_ioctl_ino_lookup_user_args) Name() string { | ||
| n := 0 | ||
| for i, b := range arg.name { | ||
| if b == '\x00' { |
Owner
There was a problem hiding this comment.
Could be replaced with bytes.IndexByte
Contributor
Author
I am working to also add respective functions that can use these as otherwise they're pretty useless as they aren't exposed to module users. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned in #8