chore: macos-15-intel runner on ci (#31419)

littledivy · web-flow · commit b18b8347f709 · 2025-12-08T23:07:44.000Z
This includes fixes from denoland/sui@e229ef1
diff --git a/.github/workflows/ci.generate.ts b/.github/workflows/ci.generate.ts
@@ -12,7 +12,7 @@ const ubuntuX86XlRunner = "ghcr.io/cirruslabs/ubuntu-runner-amd64:24.04";
 const ubuntuARMRunner = "ghcr.io/cirruslabs/ubuntu-runner-arm64:24.04";
 const windowsX86Runner = "windows-2022";
 const windowsX86XlRunner = "windows-2022-xl";
-const macosX86Runner = "macos-13";
+const macosX86Runner = "macos-15-intel";
 const macosArmRunner = "macos-14";
 const selfHostedMacosArmRunner = "ghcr.io/cirruslabs/macos-runner:sonoma";
 
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -60,12 +60,12 @@ jobs:
         include:
           - os: macos
             arch: x86_64
-            runner: macos-13
+            runner: macos-15-intel
             job: test
             profile: debug
           - os: macos
             arch: x86_64
-            runner: '${{ (!contains(github.event.pull_request.labels.*.name, ''ci-full'') && (github.event_name == ''pull_request'')) && ''ubuntu-24.04'' || ''macos-13'' }}'
+            runner: '${{ (!contains(github.event.pull_request.labels.*.name, ''ci-full'') && (github.event_name == ''pull_request'')) && ''ubuntu-24.04'' || ''macos-15-intel'' }}'
             job: test
             profile: release
             skip: '${{ !contains(github.event.pull_request.labels.*.name, ''ci-full'') && (github.event_name == ''pull_request'') }}'
@@ -765,7 +765,7 @@ jobs:
             job: lint
           - os: macos
             arch: x86_64
-            runner: macos-13
+            runner: macos-15-intel
             profile: debug
             job: lint
           - os: windows
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/Cargo.toml b/Cargo.toml
@@ -314,7 +314,7 @@ dprint-plugin-markdown = "=0.20.0"
 dprint-plugin-typescript = "=0.95.13"
 env_logger = "=0.11.6"
 fancy-regex = "=0.14.0"
-libsui = "0.11.0"
+libsui = "0.12.2"
 malva = "=0.12.1"
 markup_fmt = "=0.22.0"
 open = "5.0.1"
diff --git a/cli/standalone/binary.rs b/cli/standalone/binary.rs
@@ -180,10 +180,10 @@ pub fn is_standalone_binary(exe_path: &Path) -> bool {
   let Ok(data) = std::fs::read(exe_path) else {
     return false;
   };
-
   libsui::utils::is_elf(&data)
     || libsui::utils::is_pe(&data)
     || libsui::utils::is_macho(&data)
+    || data.is_empty()
 }
 
 pub struct WriteBinOptions<'a> {
diff --git a/tests/specs/compile/determinism/__test__.jsonc b/tests/specs/compile/determinism/__test__.jsonc
@@ -1,5 +1,6 @@
 {
   "tempDir": true,
+  "if": "notMacIntel",
   "steps": [{
     "args": [
       "eval",
diff --git a/tests/specs/compile/ffi/__test__.jsonc b/tests/specs/compile/ffi/__test__.jsonc
@@ -1,5 +1,6 @@
 {
   "tempDir": true,
+  "if": "notMacIntel",
   "steps": [{
     "args": "run -A setup.ts",
     "output": "[WILDCARD]"
diff --git a/tests/specs/compile/global_npm_cache_implicit_read_permission/__test__.jsonc b/tests/specs/compile/global_npm_cache_implicit_read_permission/__test__.jsonc
@@ -1,11 +1,11 @@
 {
   "tempDir": true,
   "steps": [{
-    "if": "unix",
+    "if": "notMacIntel",
     "args": "compile --output main main.ts",
     "output": "compile.out"
   }, {
-    "if": "unix",
+    "if": "notMacIntel",
     "commandName": "./main",
     "args": [],
     "output": "main.out"
diff --git a/tests/specs/compile/include/buffered_reads/__test__.jsonc b/tests/specs/compile/include/buffered_reads/__test__.jsonc
@@ -4,11 +4,11 @@
     "args": "run -A setup.js",
     "output": "[WILDCARD]"
   }, {
-    "if": "unix",
+    "if": "notMacIntel",
     "args": "compile --allow-read=data --include data --output main main.ts",
     "output": "[WILDCARD]"
   }, {
-    "if": "unix",
+    "if": "notMacIntel",
     "commandName": "./main",
     "args": [],
     "output": "[WILDCARD]",
diff --git a/tests/specs/compile/node_api/__test__.jsonc b/tests/specs/compile/node_api/__test__.jsonc
@@ -1,5 +1,6 @@
 {
   "tempDir": true,
+  "if": "notMacIntel",
   "steps": [{
     "args": "install --allow-scripts",
     "output": "[WILDCARD]"
diff --git a/tests/specs/compile/npm_fs/__test__.jsonc b/tests/specs/compile/npm_fs/__test__.jsonc
@@ -3,11 +3,11 @@
   // use this so the vfs output is all in the same folder
   "canonicalizedTempDir": true,
   "steps": [{
-    "if": "unix",
+    "if": "notMacIntel",
     "args": "compile -A --output main main.ts",
     "output": "compile.out"
   }, {
-    "if": "unix",
+    "if": "notMacIntel",
     "commandName": "./main",
     "args": [],
     "output": "main.out"
diff --git a/tests/specs/compile/package_json_type/__test__.jsonc b/tests/specs/compile/package_json_type/__test__.jsonc
@@ -4,11 +4,11 @@
     "args": "install",
     "output": "[WILDCARD]"
   }, {
-    "if": "unix",
+    "if": "notMacIntel",
     "args": "compile --output main main.js",
     "output": "compile.out"
   }, {
-    "if": "unix",
+    "if": "notMacIntel",
     "commandName": "./main",
     "args": [],
     "output": "output.out",
diff --git a/tests/specs/mod.rs b/tests/specs/mod.rs
@@ -484,6 +484,10 @@ fn should_run(if_cond: Option<&str>) -> bool {
       "mac" => cfg!(target_os = "macos"),
       "linux" => cfg!(target_os = "linux"),
       "notCI" => std::env::var_os("CI").is_none(),
+      "notMacIntel" => {
+        cfg!(unix)
+          && !(cfg!(target_os = "macos") && cfg!(target_arch = "x86_64"))
+      }
       value => panic!("Unknown if condition: {}", value),
     }
   } else {
diff --git a/tests/specs/npm/file_specifier/__test__.jsonc b/tests/specs/npm/file_specifier/__test__.jsonc
@@ -23,9 +23,11 @@
     "exitCode": 1,
     "output": "node_modules_dir.out"
   }, {
+    "if": "notMacIntel",
     "args": "compile --allow-read --output exec package-a/index.mjs",
     "output": "compile.out"
   }, {
+    "if": "notMacIntel",
     "commandName": "./exec",
     "args": [],
     "output": "output.out"
diff --git a/tests/specs/schema.json b/tests/specs/schema.json
@@ -48,7 +48,8 @@
             "mac",
             "linux",
             "windows",
-            "unix"
+            "unix",
+            "notMacIntel"
           ]
         },
         "output": {
@@ -103,7 +104,8 @@
               "mac",
               "linux",
               "windows",
-              "unix"
+              "unix",
+              "notMacIntel"
             ]
           },
           "repeat": {

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"tempDir": true,`
	`3`	`+ "if": "notMacIntel",`
`3`	`4`	`"steps": [{`
`4`	`5`	`"args": [`
`5`	`6`	`"eval",`