fix(ext/crypto): add support for SHA3 #31668
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Member
|
Thanks for the PR, but it doesn't look like it actually fixes the issue. Can you elaborate why you thought it will fix it? |
ChaseKnowlden
changed the title
ChaseKnowlden
force-pushed
the
issue31631
branch
from
a434a17 to
5fbcee9
Compare
Contributor
Author
|
I fixed the issue. |
Contributor
Author
|
Bump. |
bartlomieju
changed the title
bartlomieju
approved these changes
Jan 16, 2026
Member
bartlomieju
left a comment
bartlomieju
left a comment
There was a problem hiding this comment.
LGTM, @littledivy any comments?
littledivy
approved these changes
Jan 16, 2026
Member
littledivy
left a comment
littledivy
left a comment
There was a problem hiding this comment.
LGTM, maybe we can also enable WebCryptoAPI/digest/sha3.tentative.https.any.js in WPT?
Member
|
@ChaseKnowlden can you please try enabling that test Divy pointed out in |
Member
|
I spoke with Divy offline, this file is actually not available in-tree ATM. Let's merge as is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #31631
Uses ocb3 to support SHA3 for node.js tests.