fix(node/buffer): fix latin1Slice and hexSlice returning wrong results#32277
Open
bartlomieju wants to merge 1 commit intodenoland:mainfrom
Open
fix(node/buffer): fix latin1Slice and hexSlice returning wrong results#32277bartlomieju wants to merge 1 commit intodenoland:mainfrom
bartlomieju wants to merge 1 commit intodenoland:mainfrom
Conversation
Both `latin1Slice` and `hexSlice` had an extraneous `string` parameter that shifted all arguments, causing the underlying slice functions to receive wrong values. Additionally, `_latin1Slice` didn't handle missing `start`/`end` arguments, resulting in empty strings when called with no arguments. Fixes denoland#32276 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Buffer.prototype.latin1SliceandBuffer.prototype.hexSlicehaving an extraneousstringparameter that shifted all arguments passed to the underlying_latin1Slice/_hexSlicefunctions_latin1Slicenot handling missingstart/endarguments, causing it to return empty strings when called with no argumentsFixes #32276
Test plan
cargo test unit_node::buffer_testpassesBuffer.of(1,2,3,0xff).latin1Slice()returns a 4-character string (previously returned empty string)hexSlice()andhexSlice(start, end)return correct results🤖 Generated with Claude Code