fix: skip empty dependency names in package.json#32832
Open
themavik wants to merge 1 commit intodenoland:mainfrom
Open
fix: skip empty dependency names in package.json#32832themavik wants to merge 1 commit intodenoland:mainfrom
themavik wants to merge 1 commit intodenoland:mainfrom
Conversation
Root cause: An empty dependency key ("": ".") in package.json creates
a PackageReq with empty name that serializes to "@." in the lockfile.
On the next run, deserialization fails with "Invalid package requirement
'@.'", corrupting the lockfile.
Made-with: Cursor
|
themavik seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
themavik
commented
Mar 19, 2026
Author
themavik
left a comment
themavik
left a comment
There was a problem hiding this comment.
Reviewed the changes — the fix is minimal and targeted. Good contribution.
dsherret
reviewed
Mar 19, 2026
| for (key, value) in deps { | ||
| if key.is_empty() { | ||
| continue; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #32113.
Root cause: An empty dependency key (
"": ".") inpackage.jsoncreates aPackageReqwith an empty name that serializes to@.in the lockfile. On the next run, deserialization fails withInvalid package requirement '@.', corrupting the lockfile.Fix: Skip dependencies with empty names when building the package.json deps map, preventing invalid entries from being written to the lockfile.
Changes
libs/package_json/lib.rs: Added empty key check to skip invalid dependency entriesTesting