fix(cli): show clean error instead of panic for invalid --unsafely-ignore-certificate-errors value#32868
Open
bartlomieju wants to merge 1 commit intomainfrom
Open
fix(cli): show clean error instead of panic for invalid --unsafely-ignore-certificate-errors value#32868bartlomieju wants to merge 1 commit intomainfrom
bartlomieju wants to merge 1 commit intomainfrom
Conversation
…nore-certificate-errors value When a URL is passed to `--unsafely-ignore-certificate-errors` (e.g. `https://example.com/`), Deno panicked due to an `.unwrap()` on a clap validation error. This changes the parsing function to propagate the error properly, resulting in a clean error message instead of a panic. Fixes #30513 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
https://example.com/) is passed to--unsafely-ignore-certificate-errors, which only accepts domains and IPs.unsafely_ignore_certificate_errors_parseto returnclap::error::Result<()>and propagate the validation error instead of.unwrap()-ing it.upgrade_parseto propagate the error.Fixes #30513
Test plan
./target/debug/deno run --unsafely-ignore-certificate-errors=https://example.com/now printserror: invalid value 'https://example.com/': URLs are not supported, only domains and ipsinstead of panicking./target/debug/deno run --unsafely-ignore-certificate-errors=example.comstill works as before🤖 Generated with Claude Code