fix(tests): prevent task/signals spec test from hanging in CI#33020
Open
bartlomieju wants to merge 1 commit intomainfrom
Open
fix(tests): prevent task/signals spec test from hanging in CI#33020bartlomieju wants to merge 1 commit intomainfrom
bartlomieju wants to merge 1 commit intomainfrom
Conversation
The listener.ts registers signal handlers for all signals including SIGTERM, so the test harness cannot kill it on timeout. Add a 30s hard timeout in sender.ts that SIGKILLs the child (uncatchable) and fails fast. Also await child exit after SIGTERM to prevent orphaned processes. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
task/signalsspec test registers signal handlers for all signals including SIGTERM inlistener.ts, which means the test harness cannot kill it when the timeout fires — causing 30+ minute CI hangssender.tsthat SIGKILLs the child process (uncatchable) and exits with failure, so hangs fail fast with a clear errorchild.statusafter sending SIGTERM to prevent orphaned processesTest plan
./x test-spec signalspasses locally🤖 Generated with Claude Code