Skip to content

Turn block into a closure in test macro #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 14, 2020
Merged

Turn block into a closure in test macro #27

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions src/tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,15 +56,15 @@ impl DocFileLoader for TestLoader {
}

macro_rules! doc_test {
( $name:ident, $source:expr; $block:block ) => {
( $name:ident, $source:expr; $block:expr ) => {
doc_test!($name, $source, false; $block);
};

( $name:ident, $source:expr, private; $block:block ) => {
( $name:ident, $source:expr, private; $block:expr ) => {
doc_test!($name, $source, true; $block);
};

( $name:ident, $source:expr, $private:expr; $block:block ) => {
( $name:ident, $source:expr, $private:expr; $block:expr ) => {
#[tokio::test]
async fn $name() {
use swc_ecmascript::parser::Syntax;
Expand All @@ -83,7 +83,8 @@ macro_rules! doc_test {
#[allow(unused_variables)]
let doc = DocPrinter::new(&entries, false, private).to_string();

$block
#[allow(clippy::redundant_closure_call)]
($block)(entries, doc)
}
};
}
Expand All @@ -101,7 +102,7 @@ macro_rules! contains_test {

( $name:ident, $source:expr, $private:expr;
$( $contains:expr ),* $( ; $( $notcontains:expr ),* )? ) => {
doc_test!($name, $source, $private; {
doc_test!($name, $source, $private; |_entries, doc: String| {
$(
assert!(doc.contains($contains));
)*
Expand All @@ -124,7 +125,7 @@ macro_rules! json_test {
};

( $name:ident, $source:expr, $private:expr; $json:tt ) => {
doc_test!($name, $source, $private; {
doc_test!($name, $source, $private; |entries, _doc| {
let actual = serde_json::to_value(&entries).unwrap();
let expected_json = json!($json);
assert_eq!(actual, expected_json);
Expand Down