Skip to content

fix(BREAKING): use which crate and drop resolving Deno to current exe#150

Merged
dsherret merged 7 commits intodenoland:mainfrom
dsherret:use_which_sys
Jul 11, 2025
Merged

fix(BREAKING): use which crate and drop resolving Deno to current exe#150
dsherret merged 7 commits intodenoland:mainfrom
dsherret:use_which_sys

Conversation

@dsherret
Copy link
Member

@dsherret dsherret commented May 28, 2025

@dsherret dsherret marked this pull request as ready for review May 28, 2025 16:30
@dsherret dsherret requested a review from bartlomieju May 28, 2025 16:30
@dsherret dsherret changed the title refactor: use which crate fix(BREAKING): use which crate and drop resolving Deno to current exe May 28, 2025
// that don't have deno on the path and to ensure it use the current
// version of deno being executed rather than the one on the path,
// which has caused some confusion.
if command_name == EXECUTABLE_NAME {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll instead add "deno" as a custom command in the CLI.

Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsherret dsherret merged commit fc3e1cc into denoland:main Jul 11, 2025
4 checks passed
@dsherret dsherret deleted the use_which_sys branch July 11, 2025 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants