-
Notifications
You must be signed in to change notification settings - Fork 738
docs: fix misleading main.tsx filenames #3477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Can we get this merged, the documentation is terrible at best. So many conflicting stuff even when comparing with a new fresh project |
The way forward seems to be to enable This PR is just for illustration until that got fixed. |
|
@mabasic can you please elaborate more on:
What issues are you having with the docs that the community can contribute to make them better? |
I should have wrote it all down, but I was trying to get my app working asap. These are just the things that I can remember:
In conclusion, it seems like the docs were written for "route" based routing, the new app is written in file based routinf, and you probably can't mix and match both. I will publish my app soon open source so can link it here. P.S. The docker image is a good atarting point but it does not work in a monorepo. Have been trying for two days to get it working because some compilerOptions are in root deno, and some in package deno, and if you copy just the paxkage dorectory in docker, you get a bunch of errors xD |
|
@mabasic Thank you for your detailed response. Please copy your list of complaints and observations into a separate new issue. In this PR discussion they might get overlooked and forgotten. |
fix #3476
This removes misleading
main.tsxfilenames from the documentation examples.Also repetitive/slightly misleading
main.tsfilenames got removed unless they are complete copy/paste ready examples including properimportstatements.Usually one complete example with a filename on top of the doc section should be enough. Otherwise ambiguity is intentional, as there are multiple places possible to add code snippets.