-
Notifications
You must be signed in to change notification settings - Fork 47
feat: add target option #107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
README.md
Outdated
| ### Determining the target platform | ||
|
|
||
| You can determine the target platform of Deno. | ||
|
|
||
| ```yaml | ||
| - uses: denoland/setup-deno@v2 | ||
| with: | ||
| target: x86_64-pc-windows-msvc | ||
| ``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Put this further down, and explain what this is for.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add b557a7e
src/install.ts
Outdated
| await fs.rename( | ||
| path.join( | ||
| extractedFolder, | ||
| process.platform === "win32" ? "deno.exe" : "deno", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't work if you are downloading linux on windows, or windows on linux etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix 221053e
CI is failing, but the name of the rc binary seems to be strange.
expcted: deno.exe
actual: deno-x86_64-pc-windows-msvc-rc.exe
|
It seems Deno on npm is distributing a Windows x64 version as ARM. Is it possible to install Deno x64 on Windows Arm in the same way using setup-deno? |
|
Hey @ryuapp - this particular package is the regular Windows build that is run in emulation mode - we will try to look into actual arm builds later this year. So for all intents and purposes for now you can install Windows x86_64 version on ARM for the time being. |
|
Thanks for your reply.
I will run |
setup-denodoesn't allow us to determine the platform target to download, so this PR add the target option to allow it.Deno doesn't officially support Windows Arm now, but Windows Arm has some compatibility with x64, so it will work(not perfect).
I use Deno as a formatter and task runner, so I'm hoping this supports it.