test(fs): do not write files in source tree during test#6236
Merged
kt3k merged 9 commits intodenoland:mainfrom Dec 23, 2024
Merged
test(fs): do not write files in source tree during test#6236kt3k merged 9 commits intodenoland:mainfrom
kt3k merged 9 commits intodenoland:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6236 +/- ##
==========================================
- Coverage 96.52% 96.34% -0.18%
==========================================
Files 534 547 +13
Lines 40976 41661 +685
Branches 6134 6313 +179
==========================================
+ Hits 39551 40138 +587
- Misses 1383 1481 +98
Partials 42 42 ☔ View full report in Codecov by Sentry. |
iuioiua
reviewed
Dec 7, 2024
kt3k
approved these changes
Dec 23, 2024
Member
kt3k
left a comment
There was a problem hiding this comment.
LGTM. Thanks for your contribution! Also thanks for looking into the errors on windows
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request addresses the issue of files and directories being created and written into the source tree while testing functions in the
fspackage. Creation of temporary directories were incorporated into the existing tests where applicable.Fixes #5358 .