fix(fmt): add correct pluralization to fmt/duration when using style: full#6295
Merged
kt3k merged 1 commit intodenoland:mainfrom Dec 24, 2024
GriffinJohnston:fmt-duration-pluralization
Merged
fix(fmt): add correct pluralization to fmt/duration when using style: full#6295kt3k merged 1 commit intodenoland:mainfrom GriffinJohnston:fmt-duration-pluralization
kt3k merged 1 commit intodenoland:mainfrom
GriffinJohnston:fmt-duration-pluralization
Conversation
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6295 +/- ##
=======================================
Coverage 96.34% 96.34%
=======================================
Files 547 547
Lines 41661 41667 +6
Branches 6313 6314 +1
=======================================
+ Hits 40137 40144 +7
+ Misses 1482 1481 -1
Partials 42 42 ☔ View full report in Codecov by Sentry. |
GriffinJohnston
changed the title
GriffinJohnston
changed the title
GriffinJohnston
changed the title
kt3k
changed the title
kt3k
approved these changes
Dec 23, 2024
Member
kt3k
left a comment
kt3k
left a comment
There was a problem hiding this comment.
Looks reasonable to me. Thanks for your PR!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #6293